Opened 2 years ago

Closed 23 months ago

#6010 enhancement closed fixed (fixed)

Port twisted.test.test_defgen and twisted.internet.test.test_inlinecb to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/defgen-py3-6010
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description (last modified by itamar)

twisted.test.test_defgen and twisted.internet.test.test_inlinecb test inlineCallbacks and deferredGenerator. It should be ported to Python 3.

Change History (7)

comment:1 Changed 2 years ago by itamar

  • Description modified (diff)
  • Summary changed from Port twisted.test.test_defgen to Python 3 to Port twisted.test.test_defgen and twisted.internet.test.test_inlinecb to Python 3

comment:2 Changed 23 months ago by exarkun

How about not bothering with test_defgen or deferredGenerator? I just filed #6044.

comment:3 Changed 23 months ago by itamar

There are a bunch of ported tests that rely on deferredGenerator, so probably best to port it (unless it turns out to be easier to fix those tests). In particular, I suspect it will be trivial to do.

comment:4 Changed 23 months ago by itamar

  • Keywords review added
  • Owner changed from itamar to exarkun

http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/defgen-py3-6010 started.

I renamed a hidden module, removed an exec (both unnecessary now that we use modern Pythons), and fixed a couple of syntax errors in exception catching; the tests are otherwise unmodified.

comment:5 Changed 23 months ago by itamarst

  • Author set to itamarst
  • Branch set to branches/defgen-py3-6010

(In [35945]) Branching to 'defgen-py3-6010'

comment:6 Changed 23 months ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar

Thanks.

The ticket reference at the top of test_inlinecb.py doesn't seem too useful anymore? At least, these tests are no longer skipped in any way. Actually, the tests in test_defgen.py aren't skipped anymore either and there is no generator_failure_tests.py file in twisted/test/ at all. Does that mean #4182 is resolved?

No review comments about the branch itself. Please merge!

comment:7 Changed 23 months ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [35976]) Merge defgen-py3-6010.

Author: itamar
Review: exarkun
Fixes: #6010

Port deferredGenerator and inlineCallbacks tests to Python 3.

Note: See TracTickets for help on using tickets.