Ticket #6005 enhancement closed fixed

Opened 8 months ago

Last modified 8 months ago

Port twisted.internet.test.test_fdset to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/fdset-py3-6005-2
Author: itamarst Launchpad Bug:

Description

twisted.internet.test.test_fdset is a good starting point for testing the networking parts of the reactor; it should be ported to Python 3.

Change History

1

Changed 8 months ago by itamarst

  • branch set to branches/fdset-py3-6005
  • branch_author set to itamarst

(In [35741]) Branching to 'fdset-py3-6005'

2

Changed 8 months ago by itamarst

  • branch changed from branches/fdset-py3-6005 to branches/fdset-py3-6005-2

(In [35793]) Branching to 'fdset-py3-6005-2'

3

Changed 8 months ago by itamar

  • keywords review added
  • owner changed from itamar to exarkun

Started build:  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/fdset-py3-6005-2

4

Changed 8 months ago by exarkun

  • owner changed from exarkun to itamar
  • keywords review removed

Thanks. A few minor points:

  1. I don't like the new timeout=5 in test_fdset.py. Does the test hang instead of failing in a timely manner? Perhaps that could be fixed. Is that a pre-existing defect or a result of the Python 3 port? Maybe we can file a ticket and ignore it for now, since the test passes now.
  2. RemovingDescriptor should probably close read and write in connectionLost instead of doRead.
  3. Some changes to _glibbase.py but some glib-related reactors are skipped when it comes to test_fdset. intentional?

Please merge when the above are addressed.

5

Changed 8 months ago by itamar

  1. Filed #6017, removed 5 second timeout.
  2. Added explanation of why it needs to be done in doRead, plus bonus test from when I was figuring out why.
  3. I think I did this before I made skipping work in run-python3-tests. It's not longer necessary, so I reverted it.

6

Changed 8 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [35808]) Merge fdset-py3-6005-2.

Author: itamar Review: exarkun Fixes: #6005

twisted.internet.test.test_fdset now runs on Python 3; this means the reactor now kinda sorta works on Python 3.

7

Changed 8 months ago by itamarst

  • status changed from closed to reopened
  • resolution fixed deleted

(In [35812]) Revert fdset-py3-6005-2: Failing OS X tests.

Reopens: #6005.

8

Changed 8 months ago by itamar

  • keywords review added
  • status changed from reopened to new
  • owner changed from itamar to exarkun

Started another build, hopefully it'll work now.  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/fdset-py3-6005-2

9

Changed 8 months ago by exarkun

  • owner changed from exarkun to itamar
  • keywords review removed

I guess that seems okay. Perhaps not using FileDescriptor at all in the new test would be better, though, if you feel like it.

10

Changed 8 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [35821]) Merge fdset-py3-6005-2, this time for reals.

Author: itamar Review: exarkun Fixes: #6005

test_fdset works on Python 3, which probably means the reactor kinda sorta works on Python 3.

Note: See TracTickets for help on using tickets.