Opened 5 years ago

Closed 5 years ago

#6003 enhancement closed fixed (fixed)

Port `twisted.internet.udp` to Python 3

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/udp-py3-6003-2
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst

Description (last modified by Thijs Triemstra)

twisted.internet.udp should work on Python 3.

When doing this, udp imports in twisted.internet.posixbase should be moved back up to the top of the module.

Also see #6023

Change History (6)

comment:1 Changed 5 years ago by Thijs Triemstra

Description: modified (diff)

comment:2 Changed 5 years ago by itamarst

Author: itamarst
Branch: branches/udp-py3-6003-2

(In [35985]) Branching to 'udp-py3-6003-2'

comment:3 Changed 5 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: set to Jean-Paul Calderone

comment:4 Changed 5 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring
  1. Intentionally not adding twisted.internet.test.test_udp to the ported list for now? I guess it has yet unported dependencies. Should we hold off on merging this until that test module can be run to make sure all is truly well?
  2. The new test_str in twisted.internet.test.test_udp is a lot like the old test_portRepr in twisted.test.test_udp.

Otherwise looks good, but the former point seems kinda significant, unless I'm missing something.

comment:5 Changed 5 years ago by Itamar Turner-Trauring

twisted.internet.test.test_udp was ported in a previous ticket.

comment:6 Changed 5 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [36026]) Merge udp-py3-6003-2.

Author: itamar Review: exarkun Fixes: #6003

Port twisted.internet.udp to Python 3.

Note: See TracTickets for help on using tickets.