Ticket #6002 enhancement closed fixed

Opened 8 months ago

Last modified 7 months ago

Port `twisted.internet.tcp` to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/tcp-py3-6002-3
Author: itamarst Launchpad Bug:

Description

twisted.internet.tcp should work on Python 3.

When doing this, tcp imports in twisted.internet.posixbase should be moved back up to the top of the module.

Change History

1

Changed 7 months ago by itamarst

  • branch set to branches/tcp-py3-6002
  • branch_author set to itamarst

(In [36034]) Branching to 'tcp-py3-6002'

2

Changed 7 months ago by itamar

  • owner set to itamar

This only covers twisted.test.test_tcp tests; the rest of the tests will be in #6069.

3

Changed 7 months ago by itamarst

  • branch changed from branches/tcp-py3-6002 to branches/tcp-py3-6002-3

(In [36131]) Branching to 'tcp-py3-6002-3'

4

Changed 7 months ago by itamarst

(In [36131]) Branching to 'tcp-py3-6002-3'

5

Changed 7 months ago by itamar

  • owner changed from itamar to exarkun
  • keywords review added

Ready for review, I think. Started  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/tcp-py3-6002-3

6

Changed 7 months ago by exarkun

  • owner changed from exarkun to itamar
  • keywords review removed

I noticed that twisted.test.test_tcp.LargeBufferTestCase is massively slower (~40x) on Python 3. I guess we'll address that later, though (file a ticket if you feel like it, or we can just wait for someone to complain about it). So: looks good, please merge.

7

Changed 7 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [36154]) Merge tcp-py3-6002-3.

Author: itamar Review: exarkun Fixes: #6002

Port twisted.internet.tcp to Python 3.

Note: See TracTickets for help on using tickets.