Opened 4 years ago

Closed 4 years ago

#6002 enhancement closed fixed (fixed)

Port `twisted.internet.tcp` to Python 3

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/tcp-py3-6002-3
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst

Description

twisted.internet.tcp should work on Python 3.

When doing this, tcp imports in twisted.internet.posixbase should be moved back up to the top of the module.

Change History (7)

comment:1 Changed 4 years ago by itamarst

Author: itamarst
Branch: branches/tcp-py3-6002

(In [36034]) Branching to 'tcp-py3-6002'

comment:2 Changed 4 years ago by Itamar Turner-Trauring

Owner: set to Itamar Turner-Trauring

This only covers twisted.test.test_tcp tests; the rest of the tests will be in #6069.

comment:3 Changed 4 years ago by itamarst

Branch: branches/tcp-py3-6002branches/tcp-py3-6002-3

(In [36131]) Branching to 'tcp-py3-6002-3'

comment:4 Changed 4 years ago by itamarst

(In [36131]) Branching to 'tcp-py3-6002-3'

comment:5 Changed 4 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone

comment:6 Changed 4 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring

I noticed that twisted.test.test_tcp.LargeBufferTestCase is massively slower (~40x) on Python 3. I guess we'll address that later, though (file a ticket if you feel like it, or we can just wait for someone to complain about it). So: looks good, please merge.

comment:7 Changed 4 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [36154]) Merge tcp-py3-6002-3.

Author: itamar Review: exarkun Fixes: #6002

Port twisted.internet.tcp to Python 3.

Note: See TracTickets for help on using tickets.