Ticket #5975 enhancement closed fixed

Opened 8 months ago

Last modified 8 months ago

Port twisted.python.threadpool to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/threadpool-py3-5975-2
Author: itamarst Launchpad Bug:

Description

twisted.python.threadpool is used by the reactor for the default DNS lookups implementation, and therefore needs to be ported.

Change History

1

Changed 8 months ago by itamarst

  • branch set to branches/threadpool-py3-5975
  • branch_author set to itamarst

(In [35636]) Branching to 'threadpool-py3-5975'

2

Changed 8 months ago by itamar

  • keywords review added
  • owner set to exarkun

Started buildbot run, haven't looked at it yet:  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/threadpool-py3-5975

3

Changed 8 months ago by exarkun

  • status changed from new to assigned

4

Changed 8 months ago by exarkun

  • status changed from assigned to new
  • owner changed from exarkun to itamar
  • keywords review removed
  1. There's a conflict in _twistedpython3.py.
  2. The _waitForLock change allocates an extra 30MB of memory on Python 2. Can we do this loop without that extra cost?
  3. I bet some parts of threadpool.py would be clearer with context managers. For example, in _worker, with working(self): ... instead of matched append/remove calls. Would make a good ticket.

Uhh otherwise I guess this looks okay. Please merge after addressing the above.

5

Changed 8 months ago by itamarst

  • branch changed from branches/threadpool-py3-5975 to branches/threadpool-py3-5975-2

(In [35654]) Branching to 'threadpool-py3-5975-2'

6

Changed 8 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [35657]) Merge threadpool-py3-5975-2.

Author: itamar Review: exarkun Fixes: #5975

Port twisted.python.threadpool to Python 3.

Note: See TracTickets for help on using tickets.