Opened 2 years ago

Closed 2 years ago

#5975 enhancement closed fixed (fixed)

Port twisted.python.threadpool to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/threadpool-py3-5975-2
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description

twisted.python.threadpool is used by the reactor for the default DNS lookups implementation, and therefore needs to be ported.

Change History (6)

comment:1 Changed 2 years ago by itamarst

  • Author set to itamarst
  • Branch set to branches/threadpool-py3-5975

(In [35636]) Branching to 'threadpool-py3-5975'

comment:2 Changed 2 years ago by itamar

  • Keywords review added
  • Owner set to exarkun

comment:3 Changed 2 years ago by exarkun

  • Status changed from new to assigned

comment:4 Changed 2 years ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar
  • Status changed from assigned to new
  1. There's a conflict in _twistedpython3.py.
  2. The _waitForLock change allocates an extra 30MB of memory on Python 2. Can we do this loop without that extra cost?
  3. I bet some parts of threadpool.py would be clearer with context managers. For example, in _worker, with working(self): ... instead of matched append/remove calls. Would make a good ticket.

Uhh otherwise I guess this looks okay. Please merge after addressing the above.

comment:5 Changed 2 years ago by itamarst

  • Branch changed from branches/threadpool-py3-5975 to branches/threadpool-py3-5975-2

(In [35654]) Branching to 'threadpool-py3-5975-2'

comment:6 Changed 2 years ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [35657]) Merge threadpool-py3-5975-2.

Author: itamar
Review: exarkun
Fixes: #5975

Port twisted.python.threadpool to Python 3.

Note: See TracTickets for help on using tickets.