Ticket #5974 enhancement closed fixed

Opened 8 months ago

Last modified 8 months ago

Port twisted.internet.fdesc to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/fdesc-py3-5974
Author: itamarst Launchpad Bug:

Description

twisted.internet.fdesc should run on Python 3.

Attachments

fdesc.diff Download (6.5 KB) - added by itamar 8 months ago.
Port fdesc; depends on #5973

Change History

1

Changed 8 months ago by itamar

This depends on #5973; I will implement it locally and branch when that is merged.

Changed 8 months ago by itamar

Port fdesc; depends on #5973

2

Changed 8 months ago by itamar

  • keywords review added
  • owner changed from itamar to exarkun

3

Changed 8 months ago by exarkun

  • keywords review removed
  • owner changed from exarkun to itamar
  1. Blocking is a property of file descriptions, not file descriptors. At least the test method docstrings get this wrong.
  2. Existing defect, but ReadWriteTestCase docstring could use L{} and the setUp docstring says it creates two pipes when it only creates one.
  3. test_setCloseOnExec and test_unsetCloseOnExec leak the file they open.

Guess I'll look again after #5973 is resolved.

4

Changed 8 months ago by itamarst

  • branch set to branches/fdesc-py3-5974
  • branch_author set to itamarst

(In [35666]) Branching to 'fdesc-py3-5974'

5

Changed 8 months ago by itamar

I've switched docstrings to say file description, fixed docstrings, and made sure files don't leak. Started build run:

 http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/fdesc-py3-5974

6

Changed 8 months ago by itamar

  • owner changed from itamar to exarkun
  • keywords review added

7

Changed 8 months ago by exarkun

  • status changed from new to assigned

8

Changed 8 months ago by exarkun

  • status changed from assigned to new
  • owner changed from exarkun to itamar
  • keywords review removed

Looks good, please merge.

9

Changed 8 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [35683]) Merge fdesc-py3-5974.

Author: itamar Review: exarkun Fixes: #5974

Port twisted.internet.fdesc to Python 3.

Note: See TracTickets for help on using tickets.