Opened 4 years ago

Closed 4 years ago

#5974 enhancement closed fixed (fixed)

Port twisted.internet.fdesc to Python 3

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/fdesc-py3-5974
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst

Description

twisted.internet.fdesc should run on Python 3.

Attachments (1)

fdesc.diff (6.5 KB) - added by Itamar Turner-Trauring 4 years ago.
Port fdesc; depends on #5973

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by Itamar Turner-Trauring

This depends on #5973; I will implement it locally and branch when that is merged.

Changed 4 years ago by Itamar Turner-Trauring

Attachment: fdesc.diff added

Port fdesc; depends on #5973

comment:2 Changed 4 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone

comment:3 Changed 4 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring
  1. Blocking is a property of file descriptions, not file descriptors. At least the test method docstrings get this wrong.
  2. Existing defect, but ReadWriteTestCase docstring could use L{} and the setUp docstring says it creates two pipes when it only creates one.
  3. test_setCloseOnExec and test_unsetCloseOnExec leak the file they open.

Guess I'll look again after #5973 is resolved.

comment:4 Changed 4 years ago by itamarst

Author: itamarst
Branch: branches/fdesc-py3-5974

(In [35666]) Branching to 'fdesc-py3-5974'

comment:5 Changed 4 years ago by Itamar Turner-Trauring

I've switched docstrings to say file description, fixed docstrings, and made sure files don't leak. Started build run:

http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/fdesc-py3-5974

comment:6 Changed 4 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone

comment:7 Changed 4 years ago by Jean-Paul Calderone

Status: newassigned

comment:8 Changed 4 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring
Status: assignednew

Looks good, please merge.

comment:9 Changed 4 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [35683]) Merge fdesc-py3-5974.

Author: itamar Review: exarkun Fixes: #5974

Port twisted.internet.fdesc to Python 3.

Note: See TracTickets for help on using tickets.