Opened 2 years ago

Last modified 7 months ago

#5966 enhancement new

Port twisted.scripts.trial to Python 3

Reported by: exarkun Owned by: realcr
Priority: normal Milestone: Python-3.x
Component: trial Keywords: python3
Cc: jml, onelson@…, Julian+Twisted@… Branch: branches/trial-script-py3-5966
(diff, github, buildbot, log)
Author: thijs Launchpad Bug:

Description

This is the "entry point" implementation for the command line trial tool. It would be great to be able to use the command line trial tool, instead of the stdlib runner, on Python 3. Porting twisted.scripts.trial is necessary for this.

Attachments (1)

scripts_trial_py3.patch (696 bytes) - added by realcr 7 months ago.
Minor syntax changes for python3 porting.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 2 years ago by DefaultCC Plugin

  • Cc jml added

comment:2 Changed 17 months ago by onelson

  • Cc onelson@… added

comment:3 Changed 16 months ago by thijs

  • Author set to thijs
  • Branch set to branches/trial-script-py3-5966

(In [38290]) Branching to 'trial-script-py3-5966'

comment:4 Changed 16 months ago by Julian

  • Cc Julian+Twisted@… added

comment:5 Changed 7 months ago by realcr

  • Keywords python3 review added

Adding a patch to fix some syntax issues regarding python3.

  • Changes raise statement to have braces.
  • Changes except statement to have the "as" keyword.
  • Added division,absolute_import in the future import.

Changed 7 months ago by realcr

Minor syntax changes for python3 porting.

comment:6 Changed 7 months ago by Julian

  • Keywords review removed
  • Owner set to realcr

Hey! Thanks for working on these, I think we'll all be happy when trial finally does things on Py3 :).

If you haven't already, be sure to take a look at the porting plan – I think for this specifically, for one, the tests for this module (which live in twisted.trial.test.test_script) need to be runnable and pass. There are some syntax errors in it and some modules that probably need to come first, I think twisted.python.usage is probably a specific one here that probably will need knocking off before trial can run.

If you're having any trouble with these feel free to bug someone in #twisted-dev so that we're all on the same page.

Note: See TracTickets for help on using tickets.