Opened 5 years ago

Closed 22 months ago

#5966 enhancement closed duplicate (duplicate)

Port twisted.scripts.trial to Python 3

Reported by: Jean-Paul Calderone Owned by: real
Priority: normal Milestone: Python-3.x
Component: trial Keywords: python3
Cc: Jonathan Lange, Owen Nelson, Julian Berman Branch: branches/trial-script-py3-5966
branch-diff, diff-cov, branch-cov, buildbot
Author: thijs

Description

This is the "entry point" implementation for the command line trial tool. It would be great to be able to use the command line trial tool, instead of the stdlib runner, on Python 3. Porting twisted.scripts.trial is necessary for this.

Attachments (1)

scripts_trial_py3.patch (696 bytes) - added by real 3 years ago.
Minor syntax changes for python3 porting.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by DefaultCC Plugin

Cc: Jonathan Lange added

comment:2 Changed 4 years ago by Owen Nelson

Cc: Owen Nelson added

comment:3 Changed 4 years ago by Thijs Triemstra

Author: thijs
Branch: branches/trial-script-py3-5966

(In [38290]) Branching to 'trial-script-py3-5966'

comment:4 Changed 4 years ago by Julian Berman

Cc: Julian Berman added

comment:5 Changed 3 years ago by real

Keywords: python3 review added

Adding a patch to fix some syntax issues regarding python3.

  • Changes raise statement to have braces.
  • Changes except statement to have the "as" keyword.
  • Added division,absolute_import in the future import.

Changed 3 years ago by real

Attachment: scripts_trial_py3.patch added

Minor syntax changes for python3 porting.

comment:6 Changed 3 years ago by Julian Berman

Keywords: review removed
Owner: set to real

Hey! Thanks for working on these, I think we'll all be happy when trial finally does things on Py3 :).

If you haven't already, be sure to take a look at the porting plan – I think for this specifically, for one, the tests for this module (which live in twisted.trial.test.test_script) need to be runnable and pass. There are some syntax errors in it and some modules that probably need to come first, I think twisted.python.usage is probably a specific one here that probably will need knocking off before trial can run.

If you're having any trouble with these feel free to bug someone in #twisted-dev so that we're all on the same page.

comment:7 Changed 22 months ago by Adi Roiban

Resolution: duplicate
Status: newclosed

I think that twisted/script/trial was already ported in #7803

Please re-open in case I am wrong.

Thanks!

Note: See TracTickets for help on using tickets.