Opened 2 years ago

Closed 2 years ago

#5959 defect closed fixed (fixed)

Literal tabs or mixing tabs and spaces in 12.2 release

Reported by: schlenk Owned by: exarkun
Priority: normal Milestone:
Component: core Keywords: easy
Cc: thijs Branch: branches/fewer-tabs-5959
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description (last modified by thijs)

These files contain literal \x10 instead of \t, does trip some tab/spaces checkers, and mechanical replacing the tabs by spaces would even break the code.

  • twisted/names/test/test_hosts.py
  • twisted/scripts/tap2deb.py

This file mixes tabs and spaces.

  • twisted/trial/test/test_reporter.py

Found in 12.2. release tarball.

Change History (6)

comment:1 Changed 2 years ago by thijs

  • Cc thijs added
  • Description modified (diff)
  • Priority changed from low to normal
  • Type changed from enhancement to defect

comment:2 Changed 2 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/fewer-tabs-5959

(In [35580]) Branching to 'fewer-tabs-5959'

comment:3 Changed 2 years ago by exarkun

(In [35581]) Remove some trailing whitespace, replace some indentation tabs with spaces, and replace some tabs in string data with tab escapes

leave the leading tabs in tap2deb alone because they're part of a makefile and tabs mean something in a makefile. also there is no automated coverage for tap2deb.

refs #5959

comment:4 Changed 2 years ago by exarkun

  • Keywords easy review added; tabs removed

Someone else can worry about tap2deb.py, I don't want to make any more changes to it than I did.

Build results

comment:5 Changed 2 years ago by thijs

  • Keywords review removed
  • Owner set to exarkun

I've added test coverage for tab2deb in a different branch that is up for review.

Please merge, thanks.

comment:6 Changed 2 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [35645]) Merge fewer-tabs-5959

Author: exarkun
Reviewer: thijs
Fixes: #5959

Clean up some whitespace and replace some literal tabs with escape characters to avoid
ambiguity.

Note: See TracTickets for help on using tickets.