Ticket #5959 defect closed fixed

Opened 20 months ago

Last modified 20 months ago

Literal tabs or mixing tabs and spaces in 12.2 release

Reported by: schlenk Owned by: exarkun
Priority: normal Milestone:
Component: core Keywords: easy
Cc: thijs Branch: branches/fewer-tabs-5959
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description (last modified by thijs) (diff)

These files contain literal \x10 instead of \t, does trip some tab/spaces checkers, and mechanical replacing the tabs by spaces would even break the code.

  • twisted/names/test/test_hosts.py
  • twisted/scripts/tap2deb.py

This file mixes tabs and spaces.

  • twisted/trial/test/test_reporter.py

Found in 12.2. release tarball.

Change History

1

Changed 20 months ago by thijs

  • priority changed from low to normal
  • cc thijs added
  • type changed from enhancement to defect
  • description modified (diff)

2

Changed 20 months ago by exarkun

  • branch set to branches/fewer-tabs-5959
  • branch_author set to exarkun

(In [35580]) Branching to 'fewer-tabs-5959'

3

Changed 20 months ago by exarkun

(In [35581]) Remove some trailing whitespace, replace some indentation tabs with spaces, and replace some tabs in string data with tab escapes

leave the leading tabs in tap2deb alone because they're part of a makefile and tabs mean something in a makefile. also there is no automated coverage for tap2deb.

refs #5959

4

Changed 20 months ago by exarkun

  • keywords easy review added; tabs removed

Someone else can worry about tap2deb.py, I don't want to make any more changes to it than I did.

 Build results

5

Changed 20 months ago by thijs

  • owner set to exarkun
  • keywords review removed

I've added test coverage for tab2deb in a different branch that is up for review.

Please merge, thanks.

6

Changed 20 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [35645]) Merge fewer-tabs-5959

Author: exarkun Reviewer: thijs Fixes: #5959

Clean up some whitespace and replace some literal tabs with escape characters to avoid ambiguity.

Note: See TracTickets for help on using tickets.