Opened 5 years ago

Closed 5 years ago

#5959 defect closed fixed (fixed)

Literal tabs or mixing tabs and spaces in 12.2 release

Reported by: Michael Schlenker Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: core Keywords: easy
Cc: Thijs Triemstra Branch: branches/fewer-tabs-5959
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description (last modified by Thijs Triemstra)

These files contain literal \x10 instead of \t, does trip some tab/spaces checkers, and mechanical replacing the tabs by spaces would even break the code.

  • twisted/names/test/test_hosts.py
  • twisted/scripts/tap2deb.py

This file mixes tabs and spaces.

  • twisted/trial/test/test_reporter.py

Found in 12.2. release tarball.

Change History (6)

comment:1 Changed 5 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Description: modified (diff)
Priority: lownormal
Type: enhancementdefect

comment:2 Changed 5 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/fewer-tabs-5959

(In [35580]) Branching to 'fewer-tabs-5959'

comment:3 Changed 5 years ago by Jean-Paul Calderone

(In [35581]) Remove some trailing whitespace, replace some indentation tabs with spaces, and replace some tabs in string data with tab escapes

leave the leading tabs in tap2deb alone because they're part of a makefile and tabs mean something in a makefile. also there is no automated coverage for tap2deb.

refs #5959

comment:4 Changed 5 years ago by Jean-Paul Calderone

Keywords: easy review added; tabs removed

Someone else can worry about tap2deb.py, I don't want to make any more changes to it than I did.

Build results

comment:5 Changed 5 years ago by Thijs Triemstra

Keywords: review removed
Owner: set to Jean-Paul Calderone

I've added test coverage for tab2deb in a different branch that is up for review.

Please merge, thanks.

comment:6 Changed 5 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [35645]) Merge fewer-tabs-5959

Author: exarkun Reviewer: thijs Fixes: #5959

Clean up some whitespace and replace some literal tabs with escape characters to avoid ambiguity.

Note: See TracTickets for help on using tickets.