Opened 2 years ago

Closed 2 years ago

#5948 enhancement closed fixed (fixed)

Remove support for string exceptions from twisted.python.failure

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/no-string-failures-5948
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description

Python 2.6 is now minimal version, we don't need support for string exceptions and it's making Python 3 port harder.

Change History (4)

comment:1 Changed 2 years ago by itamarst

  • Author set to itamarst
  • Branch set to branches/no-string-failures-5948

(In [35530]) Branching to 'no-string-failures-5948'

comment:2 Changed 2 years ago by itamar

  • Keywords review added
  • Owner set to exarkun

Ready for review:
buildbot.twistedmatrix.com/boxes-supported?branch=/branches/no-string-failures-5948

comment:3 Changed 2 years ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar
  1. I'm mildly concerned about twisted.spread.pb.CopiedFailure, but as far as I can tell, it overrides the only Failure method which is losing support for a string type attribute (printTraceback), so I guess I shouldn't worry (at least not any more than I already did about the mere existence of a Failure subclass in twisted.spread).
  2. There's a new pyflakes warning about test_failure.py (util' imported but unused).

Otherwise looks good, please merge.

comment:4 Changed 2 years ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [35542]) Merge no-string-failures-5948: no more Failure support for string exceptions.

Author: itamar
Review: exarkun
Fixes: #5948

Failure will no longer even pretend to work with string exceptions.

Note: See TracTickets for help on using tickets.