Ticket #5942 enhancement closed fixed

Opened 10 months ago

Last modified 10 months ago

Port twisted.internet.interfaces to Python 3

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/interfaces-python3-5942
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

Most stuff in Twisted depends on this module. And conveniently, it has no behavior and no unit tests, so it just needs to be syntactically valid.

Change History

1

Changed 10 months ago by exarkun

  • branch set to branches/interfaces-python3-5942
  • branch_author set to exarkun

(In [35508]) Branching to 'interfaces-python3-5942'

2

Changed 10 months ago by exarkun

(In [35515]) Change to Python 3 compatible syntax and get rid of the two deprecated interfaces (to avoid needing to think about what to do about deprecatedModuleAttribute)

refs #5942

3

Changed 10 months ago by exarkun

(In [35523]) Okay, so there were tests, but there are not anymore.

refs #5942

4

Changed 10 months ago by exarkun

  • owner changed from exarkun to itamar
  • keywords review added

 Build results

5

Changed 10 months ago by itamar

  • keywords review removed
  • owner changed from itamar to exarkun
  1. There were some epoll failures... I think those are unrelated, though, I can't see how they'd happen because of this change, nor how they'd happen only on that build slave. You should check too just in case.
  2. Add twisted.internet and twisted.internet.interfaces to _twistedpython3.py.

Then merge. Thanks!

6

Changed 10 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [35539]) Merge interfaces-python3-5942

Author: exarkun Reviewer: itamar Fixes: #5942 Fixes: #5943 Fixes: #5944

Port twisted.internet.interfaces to Python 3. To simplify this, drop the two deprecated interfaces it previously offered, IReactorArbitrary and IFinishableConsumer. Also delete the deprecated services in twisted.application.internet which were based on IReactorArbitrary.

Note: See TracTickets for help on using tickets.