Opened 4 years ago

Closed 4 years ago

#5942 enhancement closed fixed (fixed)

Port twisted.internet.interfaces to Python 3

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/interfaces-python3-5942
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

Most stuff in Twisted depends on this module. And conveniently, it has no behavior and no unit tests, so it just needs to be syntactically valid.

Change History (6)

comment:1 Changed 4 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/interfaces-python3-5942

(In [35508]) Branching to 'interfaces-python3-5942'

comment:2 Changed 4 years ago by Jean-Paul Calderone

(In [35515]) Change to Python 3 compatible syntax and get rid of the two deprecated interfaces (to avoid needing to think about what to do about deprecatedModuleAttribute)

refs #5942

comment:3 Changed 4 years ago by Jean-Paul Calderone

(In [35523]) Okay, so there were tests, but there are not anymore.

refs #5942

comment:4 Changed 4 years ago by Jean-Paul Calderone

Keywords: review added
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring

comment:5 Changed 4 years ago by Itamar Turner-Trauring

Keywords: review removed
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone
  1. There were some epoll failures... I think those are unrelated, though, I can't see how they'd happen because of this change, nor how they'd happen only on that build slave. You should check too just in case.
  2. Add twisted.internet and twisted.internet.interfaces to _twistedpython3.py.

Then merge. Thanks!

comment:6 Changed 4 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [35539]) Merge interfaces-python3-5942

Author: exarkun Reviewer: itamar Fixes: #5942 Fixes: #5943 Fixes: #5944

Port twisted.internet.interfaces to Python 3. To simplify this, drop the two deprecated interfaces it previously offered, IReactorArbitrary and IFinishableConsumer. Also delete the deprecated services in twisted.application.internet which were based on IReactorArbitrary.

Note: See TracTickets for help on using tickets.