Opened 4 years ago

Closed 4 years ago

#5939 enhancement closed fixed (fixed)

Add Python 3 requirements to coding standard

Reported by: Itamar Turner-Trauring Owned by: Jean-Paul Calderone
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/coding-standard-py3-5939
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

All new code should be, at the very least, non-conflicting with Python 3. The coding standard should be updated appropriately. Some, but not all, items include:

  • All byte strings must start with b.
  • Exceptions must be caught except Exception as e.
  • Use of new functions and classes in twisted.python.compat, e.g. unicode.
  • All modules must have the division __future__.

Etc.

Change History (4)

comment:1 Changed 4 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/coding-standard-py3-5939

(In [35889]) Branching to 'coding-standard-py3-5939'

comment:2 Changed 4 years ago by Jean-Paul Calderone

Keywords: review added
Owner: set to Itamar Turner-Trauring

comment:3 Changed 4 years ago by Itamar Turner-Trauring

Keywords: review removed
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone

We can live with that for now until we have a complete list, yeah. The buildbot should catch most egregious problems, hopefully. Merge, with news file.

comment:4 Changed 4 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [35913]) Merge coding-standard-py3-5939

Author: exarkun Reviewer: itamar Fixes: #5939

Add a note to the coding standard about paying attention to Python 3 compatibility.

Note: See TracTickets for help on using tickets.