Opened 2 years ago

Closed 2 years ago

#5906 enhancement closed fixed (fixed)

port accumulateMethods and prefixedMethods to Python 3

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/some-reflect3-5906
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

The unit tests for SynchronousTestCase depend on these two methods.

Change History (4)

comment:1 Changed 2 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/some-reflect3-5906

(In [35364]) Branching to 'some-reflect3-5906'

comment:2 Changed 2 years ago by exarkun

  • Keywords review added
  • Owner changed from exarkun to itamar

I filed #5909 for improving the docstrings here. Build results

comment:3 Changed 2 years ago by itamar

  • Keywords review removed
  • Owner changed from itamar to exarkun

Hooray for more test coverage.

  1. You should add a note to the test module referencing #5885, for easy grepping of things that need fixing.
  2. I named the equivalent util module _utilpy3; either naming scheme is fine, we should just try to be consistent, so either rename yours or if you prefer this scheme I can rename mine.
  3. The X Y Z naming scheme is a tiny bit confusing; maybe "Base" and "Sub" and "method"?
  4. Needs news file.

Fix the above, then feel free to merge.

comment:4 Changed 2 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [35374]) Merge some-reflect3-5906

Author: exarkun
Reviewer: itamar
Fixes: #5906

Port a couple twisted.python.reflect methods to Python 3, in support of porting
a minimal subset of trial. Also, add some unit tests for these previously
untested methods.

Note: See TracTickets for help on using tickets.