Opened 5 years ago

Closed 4 years ago

#5896 enhancement closed fixed (fixed)

Port twisted.python.monkey to Python 3

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/monkey-python3-5896
branch-diff, diff-cov, branch-cov, buildbot
Author: itamar

Description

trial requires this module to run.

Change History (6)

comment:1 Changed 5 years ago by itamarst

Author: itamarst
Branch: branches/monkey-python3-5896

(In [35321]) Branching to 'monkey-python3-5896'

comment:2 Changed 5 years ago by Itamar Turner-Trauring

Author: itamarstitamar
Keywords: review added

Once again, strings need to be either native (attributes), or are for testing purposes only and so needn't be changed (values set on attributes).

http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/monkey-python3-5896

comment:3 Changed 5 years ago by Itamar Turner-Trauring

Oh, and there's full test coverage according to coverage.py.

comment:4 Changed 5 years ago by Jean-Paul Calderone

Owner: set to Jean-Paul Calderone
Status: newassigned

comment:5 Changed 5 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring
Status: assignednew
  1. fwiw, the coding standard does not call for 3 blank lines between imports and the first function/class definition. It calls for 3 blank lines between suites. Personally I like one or two blank lines separating imports from what follows.
  2. As long as we're adding __future__.division to all modules, even ones where it makes no difference, how about __future__.absolute_import too?

That's it. Please merge.

comment:6 Changed 4 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [35363]) Merge monkey-python3-5896: twisted.python.monkey now certified to run on Python 3.

Author: itamar Review: exarkun Fixes: #5896

Note: See TracTickets for help on using tickets.