Ticket #5896 enhancement closed fixed

Opened 9 months ago

Last modified 9 months ago

Port twisted.python.monkey to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/monkey-python3-5896
Author: itamar Launchpad Bug:

Description

trial requires this module to run.

Change History

1

Changed 9 months ago by itamarst

  • branch set to branches/monkey-python3-5896
  • branch_author set to itamarst

(In [35321]) Branching to 'monkey-python3-5896'

2

Changed 9 months ago by itamar

  • keywords review added
  • branch_author changed from itamarst to itamar

Once again, strings need to be either native (attributes), or are for testing purposes only and so needn't be changed (values set on attributes).

 http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/monkey-python3-5896

3

Changed 9 months ago by itamar

Oh, and there's full test coverage according to coverage.py.

4

Changed 9 months ago by exarkun

  • status changed from new to assigned
  • owner set to exarkun

5

Changed 9 months ago by exarkun

  • keywords review removed
  • status changed from assigned to new
  • owner changed from exarkun to itamar
  1. fwiw, the coding standard does not call for 3 blank lines between imports and the first function/class definition. It calls for 3 blank lines between suites. Personally I like one or two blank lines separating imports from what follows.
  2. As long as we're adding __future__.division to all modules, even ones where it makes no difference, how about __future__.absolute_import too?

That's it. Please merge.

6

Changed 9 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [35363]) Merge monkey-python3-5896: twisted.python.monkey now certified to run on Python 3.

Author: itamar Review: exarkun Fixes: #5896

Note: See TracTickets for help on using tickets.