Opened 2 years ago

Closed 2 years ago

#5896 enhancement closed fixed (fixed)

Port twisted.python.monkey to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/monkey-python3-5896
(diff, github, buildbot, log)
Author: itamar Launchpad Bug:

Description

trial requires this module to run.

Change History (6)

comment:1 Changed 2 years ago by itamarst

  • Author set to itamarst
  • Branch set to branches/monkey-python3-5896

(In [35321]) Branching to 'monkey-python3-5896'

comment:2 Changed 2 years ago by itamar

  • Author changed from itamarst to itamar
  • Keywords review added

Once again, strings need to be either native (attributes), or are for testing purposes only and so needn't be changed (values set on attributes).

http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/monkey-python3-5896

comment:3 Changed 2 years ago by itamar

Oh, and there's full test coverage according to coverage.py.

comment:4 Changed 2 years ago by exarkun

  • Owner set to exarkun
  • Status changed from new to assigned

comment:5 Changed 2 years ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar
  • Status changed from assigned to new
  1. fwiw, the coding standard does not call for 3 blank lines between imports and the first function/class definition. It calls for 3 blank lines between suites. Personally I like one or two blank lines separating imports from what follows.
  2. As long as we're adding __future__.division to all modules, even ones where it makes no difference, how about __future__.absolute_import too?

That's it. Please merge.

comment:6 Changed 2 years ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [35363]) Merge monkey-python3-5896: twisted.python.monkey now certified to run on Python 3.

Author: itamar
Review: exarkun
Fixes: #5896

Note: See TracTickets for help on using tickets.