Opened 2 years ago

Closed 2 years ago

#5878 defect closed fixed (fixed)

AdoptedStreamServerEndpoint does not implement twisted.internet.interfaces.IStreamServerEndpoint

Reported by: ashfall Owned by: ashfall
Priority: high Milestone:
Component: core Keywords: endpoint
Cc: thijs Branch: branches/interface-test-server-endpoint-5878
(diff, github, buildbot, log)
Author: ashfall Launchpad Bug:

Description (last modified by ashfall)

Also, ServerEndpointTestCaseMixin needs to have a test that checks if the endpoints provide interfaces.IStreamServerEndpoint

Change History (5)

comment:1 Changed 2 years ago by ashfall

  • Author set to ashfall
  • Branch set to branches/interface-test-server-endpoint-5878

(In [35272]) Branching to 'interface-test-server-endpoint-5878'

comment:2 Changed 2 years ago by ashfall

  • Description modified (diff)
  • Summary changed from ServerEndpointTestCaseMixin needs to have a test that checks if the endpoints provide interfaces.IStreamServerEndpoint to AdoptedStreamServerEndpoint does not implement twisted.internet.interfaces.IStreamServerEndpoint

comment:3 Changed 2 years ago by ashfall

  • Keywords review added
  • Owner ashfall deleted

comment:4 Changed 2 years ago by thijs

  • Cc thijs added
  • Keywords review removed
  • Owner set to ashfall

Thanks. Please merge.

comment:5 Changed 2 years ago by ashfall

  • Resolution set to fixed
  • Status changed from new to closed

(In [35560]) Merge interface-test-server-endpoint-5878: AdoptedStreamServerEndpoint now implements twisted.internet.interfaces.IStreamServerEndpoint

Author: ashfall
Reviewer: thijs
Fixes: #5878

Note: See TracTickets for help on using tickets.