Ticket #5847 task closed fixed

Opened 10 months ago

Last modified 2 months ago

Remove twisted/python/_epoll.c

Reported by: vperic Owned by: therve
Priority: normal Milestone:
Component: core Keywords:
Cc: thijs Branch: branches/remove-epoll-5847-2
Author: therve, vperic Launchpad Bug:

Description

Our own epoll wrapper is not built on Python2.6+. As older Python versions are no longer supported, we can remove the module and instead use the implementation in the official library.

Attched patch removes mentions of it in twisted/topfiles/setup.py and a related private helper from twisted.python.dist. The _epoll module itself (t.p._epoll.{c,pyx}) and it's tests (t.test.test_epoll) have also been removed. Finally, t.internet.epollreactor has been changed to directly refer to the select module (rather than calling it _epoll) and a conditional import was removed.

Attachments

remove-epoll.patch Download (156.4 KB) - added by vperic 10 months ago.

Change History

Changed 10 months ago by vperic

1

Changed 10 months ago by itamar

  • keywords review removed
  • owner set to vperic

Looks good; merge with a news file (a .misc is fine, since this change is not user visible in any way), and as usual only if buildbot passes on all platforms.

2

Changed 9 months ago by vperic

  • branch set to branches/remove-_epoll-5847
  • branch_author set to vperic

(In [35187]) Create branch remove-_epoll-5847

3

Changed 9 months ago by vperic

4

Changed 9 months ago by itamar

There's test failure on FreeBSD and some of the other non-Linux platforms.

5

Changed 4 months ago by thijs

  • cc thijs added

6

Changed 2 months ago by therve

  • owner changed from vperic to therve

7

Changed 2 months ago by therve

  • branch changed from branches/remove-_epoll-5847 to branches/remove-epoll-5847-2
  • branch_author changed from vperic to therve, vperic

(In [37427]) Branching to 'remove-epoll-5847-2'

8

Changed 2 months ago by therve

  • owner therve deleted
  • keywords review added

9

Changed 2 months ago by exarkun

  • owner set to exarkun
  • status changed from new to assigned

10

Changed 2 months ago by exarkun

  • status changed from assigned to new
  • owner changed from exarkun to therve
  • keywords review removed

Thanks. I'm slightly concerned that the stdlib-based epoll implementation is broken under load (< http://twistedmatrix.com/pipermail/twisted-python/2013-March/026622.html>) but I guess it's easy to revert this change later if it turns out we want to restore our version of the bindings for some reason.

Apart from that, the builds look good. The news file is missing, though. Please fix that and merge.

11

Changed 2 months ago by therve

  • status changed from new to closed
  • resolution set to fixed

(In [37439]) Merge remove-epoll-5847-2

Authors: vperic, therve Reviewers: exarkun, itamar Fixes: #5847

Remove custom epoll bindings, the epoll reactor using stdlib version since python 2.6.

Note: See TracTickets for help on using tickets.