Make twisted/test/test_text pass under Python 3

[vperic]

As before, to actually make this actually run you need to import unittest from the library, not from trial, and then "python3.2 -m unittest twisted.test.test_text" will run the tests.

The changes:

Replace calls to functions from the string module in favor of string methods (Refs: #4999); don't use the types module in favor of the "isinstance" function - types was changed in Python 3 to not include some base types, like dicts, lists and tuples.

This also required the addition of some tests.

[vperic]

First version

[antoine]

Changing exact type tests to isinstance() will change semantics: what happens e.g. to a tuple subclass?

[vperic]

As in, a tuple subclass would be caught now but not before? I guess you are right, but I could argue that the new behaviour is more correct. Right now, subclasses of those types are handled just right any other element, so printed just as a string, which is not what they're supposed to do per the doctest of stringyString; with the new code, they'll also be printed "one element per line".

The function itself isn't used anywhere, so I'm not sure what the original author intended.

Still, if I was to keep the old semantics, how should I fix this? The types module is changed in Python 3.

[antoine]

Replying to vperic:

Still, if I was to keep the old semantics, how should I fix this?

type(foo) is tuple

[vperic]

D'oh, you're right. Thanks! I'll update the patch to do just that; dropping the review tag for now.

[vperic]

Right, fixed that, thanks antoine! Putting back up for review.

[vperic]

Second version

[thijs]

Could you create a branch for the patch so we can run it on buildbot. This should rule out any test failures. Maybe once #4999 landed?

[vperic]

Yes, definitely, I'll update this once #4999 is in to contain just the py3k changes (which are minimal, really).

[itamar]

#4999 was merged, so this can now be updated.

[vperic]

(In [35184]) Create branch test_text-5830

[vperic]

I've ordered a test run on just twisted.test.test_text (as it's the only touched module). After removing the added tests, this is actually a very, very simple patch.  Build results.

[vperic]

Ok, it just occurred to me that no one actually gave this a "+1" so I'll put it up for review formally.

[thijs]

Please merge, thanks.

[vperic]

(In [35186]) Merge test_text-5830: Make t.test.test_text pass under Python 3

Author: vperic Reviewers: antoine, thijs Fixes: #5830

Don't use the types module in favor of the "type(object) is sometype" syntagm - types was changed in Python 3 to not include some base types, like dicts, lists and tuples.