update print statement in twisted.test

[thijs]

The print statement becomes print() in Python 3, and is supported in Python 2.6 and up.

twisted/test/test_newcred.py:105:        # print l[0].getBriefTraceback()
twisted/test/test_doc.py:50:                # print e
twisted/test/test_doc.py:74:                # print moduleName, "misbehaved:", e
twisted/test/test_doc.py:94:                # print e
twisted/test/test_persisted.py:340:        # print repr(uj.__dict__)
twisted/test/process_signal.py:6:print 'ok, signal us'
twisted/test/test_threads.py:331:    print 'threaded call'
twisted/test/process_linger.py:8:print "here is some text"
twisted/test/process_linger.py:10:print "goodbye"
twisted/test/test_process.py:788:        if self.verbose: print "closing stdin [%d]" % num
twisted/test/test_process.py:793:        if self.verbose: print self.pp[0].finished, self.pp[1].finished
twisted/test/test_process.py:799:        if self.verbose: print "starting processes"
twisted/test/test_process.py:821:        if self.verbose: print "kill [%d] with SIGTERM" % num
twisted/test/test_process.py:826:        if self.verbose: print self.pp[0].finished, self.pp[1].finished
twisted/test/test_process.py:829:        if self.verbose: print "starting processes"
twisted/test/test_process.py:836:        if self.verbose: print "starting processes"
twisted/test/test_process.py:843:        if self.verbose: print "starting processes"
twisted/test/test_process.py:872:            #print "len", len(self.data)
twisted/test/test_process.py:880:                #print "state2", self.state
twisted/test/process_twisted.py:27:        print "connection made"
twisted/test/process_twisted.py:33:        print "readConnectionLost"
twisted/test/process_twisted.py:36:        print "writeConnectionLost"
twisted/test/process_twisted.py:39:        print "connectionLost", reason
twisted/test/test_tcp.py:853:            print "getPeer returned non-TCP socket:", peer
twisted/test/test_tcp.py:857:            print "getHost returned non-TCP socket:", us
twisted/test/test_log.py:740:        print "This",
twisted/test/test_log.py:741:        print "is a test"
twisted/test/test_log.py:768:        print unicodeString
twisted/test/process_fds.py:12:if debug: print >>stderr, "this is stderr"
twisted/test/process_fds.py:15:if debug: print >>stderr, "read(0):", abcd
twisted/test/process_fds.py:19:if debug: print >>stderr, "os.write(1, righto)"
twisted/test/process_fds.py:24:if debug: print >>stderr, "read(3):", efgh
twisted/test/process_fds.py:28:if debug: print >>stderr, "os.close(4)"
twisted/test/process_fds.py:32:if debug: print >>stderr, "read(5):", eof
twisted/test/process_fds.py:36:if debug: print >>stderr, "os.write(1, closed)"
twisted/test/process_fds.py:39:if debug: print >>stderr, "sys.exit(0)"
twisted/test/test_paths.py:287:            # print fspath, '=>', arcpath
twisted/test/iosim.py:219:            print '-- GLUG --'
twisted/test/iosim.py:225:            print '.'
twisted/test/iosim.py:228:                print 'C: '+repr(cData)
twisted/test/iosim.py:230:                print 'S: '+repr(sData)
twisted/test/iosim.py:240:                print '* C'
twisted/test/iosim.py:247:                print '* S'
twisted/test/test_dirdbm.py:37:        # print s['key']
twisted/test/test_banana.py:206:        # print repr(crashString)
twisted/test/process_cmdline.py:5:    print x
twisted/test/crash_test_dummy.py:17:        #print 'X',self.x,'doing!'
twisted/test/test_internet.py:1014:        print 'done', res
twisted/test/test_internet.py:1017:        print 'failed'

[thijs]

Should those prints that are commented out be fixed as well or removed?

[vperic]

I'd personally leave them as is (or delete them if they are obviously bogus).. on the other hand, there's like 10 of them so might as well convert them, no reason to stall this ticket because of that. BTW, you can use the 2to3 fixer to make these changes automatically: 2to3 -f print -w -n twisted/test and then just add the __future__ imports manually. At least all of these changes will be covered. :)

[thijs]

Attached patch replaces the active print() statements in twisted.test

[vperic]

In twisted.test.test_internet, there is a string, "resolve_helper", which then gets written to a file and executes, which has print statements. I guess it should be updated also.

Other than that, looks good to me, but last time I reviewed something I had to revert the change, so I'll let someone else take a look. :)

[thijs]

Replying to vperic:

In twisted.test.test_internet, there is a string, "resolve_helper", which then gets written to a file and executes, which has print statements. I guess it should be updated also. Other than that, looks good to me, but last time I reviewed something I had to revert the change, so I'll let someone else take a look. :)

I should've made a branch and run it against buildbot, let me do that here as well.

[thijs]

(In [35052]) Branching to 'print-tests-5812'

[thijs]

(In [35056]) apply print-core-tests-5812.patch, add news file. refs #5812

[thijs]

The prints in resolve_helper were fixed and build results are  here.

[khorn]

Looks pretty good, except:

The following files don't have:

from __future__ import print_function

and probably should for 2.6 compatibility.

twisted/test/iosim.py twisted/test/process_cmdline.py twisted/test/process_linger.py twisted/test/process_signal.py twisted/test/test_internet.py