Ticket #5810 enhancement closed wontfix

Opened 10 months ago

Last modified 6 months ago

replace usage of file/open with FilePath in twisted.names

Reported by: thijs Owned by: thijs
Priority: normal Milestone:
Component: names Keywords: easy
Cc: thijs Branch: branches/names-filepath-5810-2
Author: thijs Launchpad Bug:

Description (last modified by thijs) (diff)

The usage of file() and open() should be replaced with FilePath in twisted.names and it's tests (also for Python 3 compatibility). 

twisted/names/test/test_names.py:635:        fObj = file(resolvConf, 'w')
twisted/names/client.py:151:            resolvConf = file(self.resolv)
twisted/names/authority.py:30:            f = file(filename, 'w')
twisted/names/authority.py:36:    serialFile = file(filename, 'r')
twisted/names/authority.py:40:    serialFile = file(filename, 'w')

Attachments

names-open-5810.patch Download (3.5 KB) - added by thijs 10 months ago.

Change History

Changed 10 months ago by thijs

1

Changed 10 months ago by thijs

  • keywords review added

2

Changed 10 months ago by antoine

  • keywords review removed
  • owner set to thijs

Patch looks fine to me.

3

Changed 10 months ago by thijs

  • description modified (diff)
  • summary changed from replace usage of file with open in twisted.names to replace usage of file with FilePath in twisted.names

4

Changed 8 months ago by thijs

  • branch set to branches/names-filepath-5810
  • branch_author set to thijs

(In [35920]) Branching to 'names-filepath-5810'

5

Changed 8 months ago by thijs

  • status changed from new to assigned
  • description modified (diff)
  • summary changed from replace usage of file with FilePath in twisted.names to replace usage of file/open with FilePath in twisted.names

6

Changed 7 months ago by thijs

  • branch changed from branches/names-filepath-5810 to branches/names-filepath-5810-2

(In [36318]) Branching to 'names-filepath-5810-2'

7

Changed 7 months ago by thijs

(In [36319]) replace file with FilePath, add news file. refs #5810

8

Changed 7 months ago by thijs

  • status changed from assigned to new
  • keywords review added
  • owner thijs deleted

Up for review.

9

Changed 6 months ago by therve

  • keywords review removed
  • owner set to thijs

I'm not sure I'm following, but as far as I understand this branch doesn't help creating more tests that pass under py3. twisted/names/authority.py is still unimportable for example. I think the porting strategy has changed from "change some bits to be compatible" to "port a module and its tests". If I get that right this ticket should be closed as invalid.

10

Changed 6 months ago by therve

  • status changed from new to closed
  • resolution set to wontfix

Following Plan/Python3 I'm closing this ticket. Sorry for the inconvenience.

Note: See TracTickets for help on using tickets.