replace usage of file with FilePath in twisted.cred.checkers

[thijs]

The usage of file should be replaced with FilePath in twisted.cred.checkers and it's tests for Python 3 compatibility.

twisted/cred/checkers.py:196:            f = file(self.filename)
twisted/test/test_newcred.py:184:        f = file(dbfile, 'w')
twisted/test/test_newcred.py:196:        f = file(dbfile, 'w')
twisted/test/test_newcred.py:207:        f = file(dbfile, 'w')
twisted/test/test_newcred.py:220:        f = file(dbfile, 'w')
twisted/test/test_newcred.py:246:        f = file(dbfile, 'w')
twisted/test/test_newcred.py:408:            fObj = file(fn, 'w')
twisted/test/test_newcred.py:415:            fObj = file(fn, 'w')
twisted/test/test_newcred.py:422:            fObj = file(fn, 'w')

[thijs]

Attached patch replaces file with with open(...) as f and also applies some coding standards.

[namn]

setUp and test_userLookup in OnDiskDatabaseTestCase.py should be separated by two blank lines.

setUp is defined in two places, one at line 247, one at 184. The later definition does not assign dbfile to self.

[thijs]

Replying to namn:

setUp and test_userLookup in OnDiskDatabaseTestCase.py should be separated by two blank lines. setUp is defined in two places, one at line 247, one at 184. The later definition does not assign dbfile to self.

Thanks for the review. Make sure to remove the 'review' keyword when you've done a review, as described on ReviewProcess.

[thijs]

(In [35910]) Branching to 'checkers-filepath-5808'

[thijs]

(In [35911]) apply cred-open-5808-2.patch, refs #5808

[thijs]

(In [35919]) address review comments, add news file. refs #5808

[therve]

Following Plan/Python3 I'm closing this ticket. Sorry for the inconvenience.