Opened 2 years ago

Closed 20 months ago

#5801 defect closed fixed (fixed)

Missing test coverage for SSL client endpoint string description parser

Reported by: exarkun Owned by: tom.prince
Priority: normal Milestone:
Component: core Keywords: endpoints easy
Cc: Branch: branches/ssl-client-endpoint-parser-test-5801-2
(diff, github, buildbot, log)
Author: ashfall, tomprince Launchpad Bug:

Description

The default for certKey is untested, as is the default for sslmethod.

Attachments (1)

ssl-client-endpoint-test-defaults-5801.patch (1.6 KB) - added by ecnahc515 21 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 2 years ago by ashfall

  • Owner set to ashfall

This looks like something I do a lot.

comment:2 Changed 2 years ago by ashfall

  • Author set to ashfall
  • Branch set to branches/ssl-client-endpoint-parser-test-5801

(In [34995]) Branching to 'ssl-client-endpoint-parser-test-5801'

Changed 21 months ago by ecnahc515

comment:3 Changed 21 months ago by ecnahc515

  • Keywords review added
  • Owner ashfall deleted

Added a new test which tests that default values for the ssl client endpoint string parser are set.

comment:4 Changed 20 months ago by tomprince

  • Author changed from ashfall to ashfall, tomprince
  • Branch changed from branches/ssl-client-endpoint-parser-test-5801 to branches/ssl-client-endpoint-parser-test-5801-2

(In [37818]) Branching to ssl-client-endpoint-parser-test-5801-2.

comment:5 Changed 20 months ago by tom.prince

  • Keywords review removed
  • Owner set to tom.prince

build results

This looks good. I've slightly expanded the docstring, to be more precise. I'll merge this.

comment:6 Changed 20 months ago by tom.prince

And, it needs a topfile.

comment:7 Changed 20 months ago by tomprince

  • Resolution set to fixed
  • Status changed from new to closed

(In [37824]) Merge ssl-client-endpoint-parser-test-5801-2: Add missing test coverage for SSL client endpoint string description parser

Author: ecnahc515
Reviewers: tom.prince
Fixes: #5801

Note: See TracTickets for help on using tickets.