Ticket #5801 defect closed fixed

Opened 21 months ago

Last modified 13 months ago

Missing test coverage for SSL client endpoint string description parser

Reported by: exarkun Owned by: tom.prince
Priority: normal Milestone:
Component: core Keywords: endpoints easy
Cc: Branch: branches/ssl-client-endpoint-parser-test-5801-2
(diff, github, buildbot, log)
Author: ashfall, tomprince Launchpad Bug:

Description

The default for certKey is untested, as is the default for sslmethod.

Attachments

ssl-client-endpoint-test-defaults-5801.patch Download (1.6 KB) - added by ecnahc515 14 months ago.

Change History

1

Changed 21 months ago by ashfall

  • owner set to ashfall

This looks like something I do a lot.

2

Changed 21 months ago by ashfall

  • branch set to branches/ssl-client-endpoint-parser-test-5801
  • branch_author set to ashfall

(In [34995]) Branching to 'ssl-client-endpoint-parser-test-5801'

Changed 14 months ago by ecnahc515

3

Changed 14 months ago by ecnahc515

  • owner ashfall deleted
  • keywords review added

Added a new test which tests that default values for the ssl client endpoint string parser are set.

4

Changed 13 months ago by tomprince

  • branch changed from branches/ssl-client-endpoint-parser-test-5801 to branches/ssl-client-endpoint-parser-test-5801-2
  • branch_author changed from ashfall to ashfall, tomprince

(In [37818]) Branching to ssl-client-endpoint-parser-test-5801-2.

5

Changed 13 months ago by tom.prince

  • keywords review removed
  • owner set to tom.prince

 build results

This looks good. I've slightly expanded the docstring, to be more precise. I'll merge this.

6

Changed 13 months ago by tom.prince

And, it needs a topfile.

7

Changed 13 months ago by tomprince

  • status changed from new to closed
  • resolution set to fixed

(In [37824]) Merge ssl-client-endpoint-parser-test-5801-2: Add missing test coverage for SSL client endpoint string description parser

Author: ecnahc515 Reviewers: tom.prince Fixes: #5801

Note: See TracTickets for help on using tickets.