Opened 5 years ago

Closed 4 years ago

#5801 defect closed fixed (fixed)

Missing test coverage for SSL client endpoint string description parser

Reported by: Jean-Paul Calderone Owned by: Tom Prince
Priority: normal Milestone:
Component: core Keywords: endpoints easy
Cc: Branch: branches/ssl-client-endpoint-parser-test-5801-2
branch-diff, diff-cov, branch-cov, buildbot
Author: ashfall, tomprince

Description

The default for certKey is untested, as is the default for sslmethod.

Attachments (1)

ssl-client-endpoint-test-defaults-5801.patch (1.6 KB) - added by Chance Zibolski 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by ashfall

Owner: set to ashfall

This looks like something I do a lot.

comment:2 Changed 5 years ago by ashfall

Author: ashfall
Branch: branches/ssl-client-endpoint-parser-test-5801

(In [34995]) Branching to 'ssl-client-endpoint-parser-test-5801'

Changed 4 years ago by Chance Zibolski

comment:3 Changed 4 years ago by Chance Zibolski

Keywords: review added
Owner: ashfall deleted

Added a new test which tests that default values for the ssl client endpoint string parser are set.

comment:4 Changed 4 years ago by Tom Prince

Author: ashfallashfall, tomprince
Branch: branches/ssl-client-endpoint-parser-test-5801branches/ssl-client-endpoint-parser-test-5801-2

(In [37818]) Branching to ssl-client-endpoint-parser-test-5801-2.

comment:5 Changed 4 years ago by Tom Prince

Keywords: review removed
Owner: set to Tom Prince

build results

This looks good. I've slightly expanded the docstring, to be more precise. I'll merge this.

comment:6 Changed 4 years ago by Tom Prince

And, it needs a topfile.

comment:7 Changed 4 years ago by Tom Prince

Resolution: fixed
Status: newclosed

(In [37824]) Merge ssl-client-endpoint-parser-test-5801-2: Add missing test coverage for SSL client endpoint string description parser

Author: ecnahc515 Reviewers: tom.prince Fixes: #5801

Note: See TracTickets for help on using tickets.