Replace usage of file with open in twisted.python.versions

[thijs]

twisted.python.versions contains 2 file calls that are deprecated in Python 3, and should be replaced with open instead.

twisted/python/versions.py:212:                format = file(formatFile).read().strip()
twisted/python/versions.py:223:            entries = file(entriesFile)

Attached patch replaces these calls and also brings code coverage from 92 to 98%.

[antoine]

I can't comment on the new tests, but the change in twisted.python.versions looks obviously fine. Of course, you could have taken the opportunity to use a "with" statement (and perhaps made explicit the "r" argument to open(), but that's a personal preference) :-)

[thijs]

Replying to antoine:

I can't comment on the new tests, but the change in twisted.python.versions looks obviously fine. Of course, you could have taken the opportunity to use a "with" statement (and perhaps made explicit the "r" argument to open(), but that's a personal preference) :-)

Thanks for the review, I added the 'r' argument in the latest patch.

[vperic]

This looks good to me. There's also some overlap with ticket #5627, but lets wait for this to get in and I'll take care of the other ticket. I guess a topfile should be added and tests run, but other than that +1 from me.

[thijs]

(In [34948]) Apply versions-5785-2.patch: Replace the usage of file with open in twisted.python.versions for Python 3 compatibility.

Author: thijs Reviewer: antoine, vperic Fixes: #5785 Refs #5627

[vperic]

(In [34973]) Revert r34948: Apply versions-5785-2.patch

The commit added a test, test_dontAllowOtherObjects, which compares a Version with a string object. It is however not reliable, as it compares memory addresses, so revert the whole commit.

Reopens: #5785

[thijs]

Replying to vperic:

(In [34973]) Revert r34948: Apply versions-5785-2.patch The commit added a test, test_dontAllowOtherObjects, which compares a Version with a string object. It is however not reliable, as it compares memory addresses, so revert the whole commit. Reopens: #5785

Ugh. I will prepare a new patch for this.

[vperic]

Hi, in #5627 I submitted a patch to remove cmp which has a similar test, so please don't duplicate work.

[thijs]

Replying to vperic:

Hi, in #5627 I submitted a patch to remove cmp which has a similar test, so please don't duplicate work.

I'm aware of this and will hold off with this work until #5627 has landed.

[itamarst]

(In [35325]) Branching to 'versions-file-5785'

[exarkun]

(In [35431]) Merge versions-python3-5917-3

Author: exarkun Reviewer: itamar Fixes: #5917 Fixes: #5785 Fixes: #5886

Port twisted.python.versions to Python 3. Also add a bit of missing test coverage and restore the definition of twisted.__version__ on Python 3.