Ticket #5777 regression closed fixed

Opened 10 months ago

Last modified 10 months ago

Conch tests are failing if PyCrypto or PyASN1 is not installed

Reported by: Alex Owned by: exarkun
Priority: highest Milestone:
Component: conch Keywords:
Cc: z3p Branch:
Author: Launchpad Bug:

Description (last modified by exarkun) (diff)

Currently (as of r34749 / #5776) they fail if you don't have either of these packages installed, in that case they should be skipped.

Attachments

t5777-failing-tests.diff Download (0.7 KB) - added by Alex 10 months ago.

Change History

1

Changed 10 months ago by DefaultCC Plugin

  • cc z3p added

Changed 10 months ago by Alex

2

Changed 10 months ago by Alex

  • keywords review added

3

Changed 10 months ago by exarkun

  • description modified (diff)

4

Changed 10 months ago by ralphm

  • owner set to Alex
  • keywords review removed

This change looks good to me.

  • I'm ignoring the pyflakes warnings caused by the (unused) imports at the top that are there for the side effect of checking if the modules are there.
  • Nice typo fix.
  • When this is merged a news file needs to be added.

Please merge (with a news file).

5

Changed 10 months ago by exarkun

  • status changed from new to assigned
  • owner changed from Alex to exarkun

6

Changed 10 months ago by exarkun

  • status changed from assigned to closed
  • resolution set to fixed

(In [34768]) Skip some Conch tests if dependencies are missing

Author: Alex Reviewer: ralphm Fixes: #5777

Note: See TracTickets for help on using tickets.