Update the test suite to not use the deprecated assertion methods

[Julian]

Following up on #4990, the test suite should use the assert* style methods.

This ticket is a preliminary requirement for merging #4991.

[exarkun]

Thanks for working on this issue. The maximum patch length for review is about 800 lines, whereas this one comes in at over 10,000 lines. I suggest splitting the work up by sub-project (and for core, splitting it up even more than that). Then the patch can be addressed piece by piece, and no one has to try to read and accept over ten thousand lines of changes all at once. Each patch should have its own ticket.

Thanks again.

[jknight]

Meh.

It's only 3324 lines if you eliminate all the context lines. And, bonus, it looks easier to review that way too (seriously, not even joking; don't need context to see that self.failUnless(...) -> self.assertTrue(...) is right.)

I expect the changes to trial itself to be an issue (may want to continue using deprecated methods in tests for the deprecated methods, for example), so certainly that set of changes should be examined with more care. But the rest looks pretty darn obvious...

[glyph]

Replying to jknight:

It's only 3324 lines if you eliminate all the context lines. And, bonus, it looks easier to review that way too (seriously, not even joking; don't need context to see that self.failUnless(...) -> self.assertTrue(...) is right.) I expect the changes to trial itself to be an issue (may want to continue using deprecated methods in tests for the deprecated methods, for example), so certainly that set of changes should be examined with more care. But the rest looks pretty darn obvious...

Do you want to do the code review on it, then?

[Julian]

This is being broken up and done in tickets #6220 - #6233.

Closing as a duplicate since there isn't really anything useful here.