Opened 2 years ago

Last modified 18 months ago

#5770 task new

Deprecate IntNStringReceiver.recvd

Reported by: therve Owned by: therve
Priority: low Milestone:
Component: core Keywords:
Cc: Branch: branches/deprecated-recvd-5770
(diff, github, buildbot, log)
Author: therve Launchpad Bug:

Description

It was kept for compatibility purpose when the latest optimization was introduced, it should be deprecated.

Change History (7)

comment:1 Changed 2 years ago by therve

  • Summary changed from Deprecate IntNStringReceiver.recv to Deprecate IntNStringReceiver.recvd

comment:2 Changed 19 months ago by therve

  • Author set to therve
  • Branch set to branches/deprecated-recvd-5770

(In [37980]) Branching to 'deprecated-recvd-5770'

comment:3 Changed 19 months ago by therve

  • Owner set to therve

comment:4 Changed 19 months ago by therve

  • Keywords review added
  • Owner therve deleted

comment:5 Changed 18 months ago by glyph

  • Keywords review removed
  • Owner set to therve

Thanks for fixing this.

Looks fine, modulo some minor points:

  1. I think that these pyflakes errors are spurious, but if not, fix it.
  2. clearBuffer's docstring really should be a lot better. What is "the current buffer"? It might be best to describe this in terms of the behavior of stringReceived and dataReceived.
  3. # new protocol: luckily it's giving that with a handy method is not a very useful comment. Perhaps if clearBuffer's docstring explained what it did, this comment could simply be eliminated.

Please address to your satisfaction and merge.

comment:6 Changed 18 months ago by exarkun

Do we not care that clearing a buffer provides a smaller feature set than being able to assign to recvd? It might be nice to see a unit test that does the same thing as test_recvdChanged without using a deprecated API. And it seems like we're just discarding the feature of being able to inspect the current buffer?

comment:7 Changed 18 months ago by exarkun

Also, doesn't the set-case warning point to the wrong code? The test asks for deprecations pointed at test_recvdChanged, but that's not where the code that writes to recvd is.

Note: See TracTickets for help on using tickets.