Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5768 task closed fixed (fixed)

Remove deprecated twisted.web.google

Reported by: thijs Owned by: spiv
Priority: low Milestone:
Component: web Keywords:
Cc: thijs, jknight Branch: branches/remove-google-5768
(diff, github, buildbot, log)
Author: thijs Launchpad Bug:

Description

twisted.web.google was deprecated in Twisted 11.1 (#5209) and can be removed (inc. the sample).

Attachments (1)

google-5678.patch (5.5 KB) - added by thijs 2 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 2 years ago by DefaultCC Plugin

  • Cc jknight added

Changed 2 years ago by thijs

comment:2 Changed 2 years ago by thijs

  • Author set to thijs
  • Keywords review added

comment:3 Changed 2 years ago by spiv

  • Owner set to spiv

comment:4 Changed 2 years ago by spiv

  • Author changed from thijs to thijs, spiv
  • Branch set to branches/remove-google-5768

(In [34792]) Branch to remove-google-5768

comment:5 Changed 2 years ago by spiv

  • Author changed from thijs, spiv to thijs
  • Keywords review removed

Tests pass locally, and it's hard to object to deleting code! I don't have a single nitpick to make.

Assuming buildbot likes this I'll submit it. Thank you!

comment:6 Changed 2 years ago by spiv

  • Resolution set to fixed
  • Status changed from new to closed

(In [34796]) Merge remove-google-5768: Remove the deprecated twisted.web.google module.

Author: thijs
Reviewer: spiv
Fixes: #5768

Removes twisted.web.google, which was deprecated in Twisted 11.1, and
associated documentation.

comment:7 Changed 2 years ago by glyph

Hello eager deprecators (especially Thijs):

In this case I don't object to the removal, because the code we're talking about here can arguably be said to violate Google's terms of service and we should never have shipped it in the first place. (You should be using the google custom search API if you want to automate things, which this module never supported.)

However, tickets like this should be worded so as to explain that the code should be removed for a reason (such as "maybe it violates Google's terms of service"). The fact that code can be removed does not necessarily mean that it should be. Deprecated code should be removed for a specific reason, when it becomes an unreasonable maintenance burden, or if its presence is for some reason confusing or problematic.

Generally, we should hang on to deprecated functionality unless it starts to cause us problems and there is a reason to remove it; doing otherwise is by definition breaking people's programs for no reason.

So, again, no problem with this specific ticket (there is a great reason to remove this code, it just wasn't clearly described), but I am concerned over the general pattern of removing things as soon as we possibly can according to policy. In the future, let's start with a description of why we want to remove it.

Thanks,

-glyph

Note: See TracTickets for help on using tickets.