Opened 2 years ago

Closed 2 years ago

#5766 task closed fixed (fixed)

Remove deprecated unzip and unzipIter in twisted.python.zipstream

Reported by: thijs Owned by: thijs
Priority: low Milestone:
Component: core Keywords:
Cc: thijs Branch: branches/remove-unzip-5766
(diff, github, buildbot, log)
Author: thijs Launchpad Bug:

Description (last modified by thijs)

unzip and unzipIter in twisted.python.zipstream were deprecated in Twisted 11.0 and can be removed.

Same goes for countZipFileEntries, deprecated in r22464.

Attachments (1)

zipstream-5766.patch (15.1 KB) - added by thijs 2 years ago.

Download all attachments as: .zip

Change History (7)

Changed 2 years ago by thijs

comment:1 Changed 2 years ago by thijs

  • Author set to thijs
  • Description modified (diff)
  • Keywords review added

comment:2 Changed 2 years ago by exarkun

  • Keywords review removed
  • Owner set to thijs

The capitalization and punctuation changes in this patch are questionable. If they came with improvements to the actual content of the documentation itself, I'd be happy to accept them. Twiddling with periods for its own sake strikes me as a great waste of time though.

Please put this patch in a branch and verify that it passes on all builders. If it does, go ahead and merge.

comment:3 Changed 2 years ago by thijs

  • Branch set to branches/remove-unzip-5766

(In [35093]) Branching to 'remove-unzip-5766'

comment:4 Changed 2 years ago by thijs

(In [35094]) apply zipstream-5766.patch without punctuation, refs #5766

comment:5 Changed 2 years ago by thijs

  • Status changed from new to assigned

Thanks for the review. The patch was committed without the punctuation changes: Build results.

comment:6 Changed 2 years ago by thijs

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [35095]) Merge remove-unzip-5766: unzip, unzipIter, and countZipFileEntries in twisted.python.zipstream (deprecated in Twisted 11.0) are removed now.

Author: thijs
Reviewer: exarkun
Fixes: #5766

Note: See TracTickets for help on using tickets.