Ticket #5766 task closed fixed

Opened 11 months ago

Last modified 10 months ago

Remove deprecated unzip and unzipIter in twisted.python.zipstream

Reported by: thijs Owned by: thijs
Priority: low Milestone:
Component: core Keywords:
Cc: thijs Branch: branches/remove-unzip-5766
Author: thijs Launchpad Bug:

Description (last modified by thijs) (diff)

unzip and unzipIter in twisted.python.zipstream were deprecated in Twisted 11.0 and can be removed.

Same goes for countZipFileEntries, deprecated in r22464.

Attachments

zipstream-5766.patch Download (15.1 KB) - added by thijs 11 months ago.

Change History

Changed 11 months ago by thijs

1

Changed 11 months ago by thijs

  • keywords review added
  • description modified (diff)
  • branch_author set to thijs

2

Changed 10 months ago by exarkun

  • keywords review removed
  • owner set to thijs

The capitalization and punctuation changes in this patch are questionable. If they came with improvements to the actual content of the documentation itself, I'd be happy to accept them. Twiddling with periods for its own sake strikes me as a great waste of time though.

Please put this patch in a branch and verify that it passes on all builders. If it does, go ahead and merge.

3

Changed 10 months ago by thijs

  • branch set to branches/remove-unzip-5766

(In [35093]) Branching to 'remove-unzip-5766'

4

Changed 10 months ago by thijs

(In [35094]) apply zipstream-5766.patch without punctuation, refs #5766

5

Changed 10 months ago by thijs

  • status changed from new to assigned

Thanks for the review. The patch was committed without the punctuation changes:  Build results.

6

Changed 10 months ago by thijs

  • status changed from assigned to closed
  • resolution set to fixed

(In [35095]) Merge remove-unzip-5766: unzip, unzipIter, and countZipFileEntries in twisted.python.zipstream (deprecated in Twisted 11.0) are removed now.

Author: thijs Reviewer: exarkun Fixes: #5766

Note: See TracTickets for help on using tickets.