Opened 5 years ago

Closed 5 years ago

#5766 task closed fixed (fixed)

Remove deprecated unzip and unzipIter in twisted.python.zipstream

Reported by: Thijs Triemstra Owned by: Thijs Triemstra
Priority: low Milestone:
Component: core Keywords:
Cc: Thijs Triemstra Branch: branches/remove-unzip-5766
branch-diff, diff-cov, branch-cov, buildbot
Author: thijs

Description (last modified by Thijs Triemstra)

unzip and unzipIter in twisted.python.zipstream were deprecated in Twisted 11.0 and can be removed.

Same goes for countZipFileEntries, deprecated in r22464.

Attachments (1)

zipstream-5766.patch (15.1 KB) - added by Thijs Triemstra 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by Thijs Triemstra

Attachment: zipstream-5766.patch added

comment:1 Changed 5 years ago by Thijs Triemstra

Author: thijs
Description: modified (diff)
Keywords: review added

comment:2 Changed 5 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to Thijs Triemstra

The capitalization and punctuation changes in this patch are questionable. If they came with improvements to the actual content of the documentation itself, I'd be happy to accept them. Twiddling with periods for its own sake strikes me as a great waste of time though.

Please put this patch in a branch and verify that it passes on all builders. If it does, go ahead and merge.

comment:3 Changed 5 years ago by Thijs Triemstra

Branch: branches/remove-unzip-5766

(In [35093]) Branching to 'remove-unzip-5766'

comment:4 Changed 5 years ago by Thijs Triemstra

(In [35094]) apply zipstream-5766.patch without punctuation, refs #5766

comment:5 Changed 5 years ago by Thijs Triemstra

Status: newassigned

Thanks for the review. The patch was committed without the punctuation changes: Build results.

comment:6 Changed 5 years ago by Thijs Triemstra

Resolution: fixed
Status: assignedclosed

(In [35095]) Merge remove-unzip-5766: unzip, unzipIter, and countZipFileEntries in twisted.python.zipstream (deprecated in Twisted 11.0) are removed now.

Author: thijs Reviewer: exarkun Fixes: #5766

Note: See TracTickets for help on using tickets.