Ticket #5765 task closed fixed

Opened 22 months ago

Last modified 22 months ago

Remove deprecated code in twisted.python.log

Reported by: thijs Owned by: spiv
Priority: low Milestone:
Component: core Keywords:
Cc: thijs Branch: branches/remove-deprecated-log-functions-5765
(diff, github, buildbot, log)
Author: Launchpad Bug:

Description

The following methods in twisted.python.log are deprecated since Twisted 2.5 and can be removed:

  • startKeepingErrors
  • flushErrors and _flushErrors
  • ignoreErrors and _ignore
  • clearIgnores and _clearIgnores

Attachments

log-5765.patch Download (4.2 KB) - added by thijs 22 months ago.

Change History

Changed 22 months ago by thijs

1

Changed 22 months ago by thijs

  • keywords review added

2

Changed 22 months ago by spiv

  • owner set to spiv
  • status changed from new to assigned

3

Changed 22 months ago by spiv

  • status changed from assigned to new
  • owner changed from spiv to thijs
  • keywords review removed

I don't understand why twisted.trial.unittest._LogObserver._add still assigns to log._flushErrors etc. Isn't the point of this patch that log._flushErrors and friends don't exist anymore?

If those lines were deleted, this patch looks fine to me.

4

Changed 22 months ago by spiv

  • status changed from new to assigned
  • owner changed from thijs to spiv

As I expected, tests still pass without those lines. I'll make that change and put it up for review.

5

Changed 22 months ago by spiv

  • keywords review added
  • branch set to branches/remove-deprecated-log-functions5765

6

Changed 22 months ago by spiv

  • branch changed from branches/remove-deprecated-log-functions5765 to branches/remove-deprecated-log-functions-5765

7

Changed 22 months ago by spiv

  • owner spiv deleted
  • status changed from assigned to new

8

Changed 22 months ago by cyli

  • keywords review removed
  • owner set to spiv

Thanks for reviewing and fixing this spiv! I was wondering about those too - this looks good to me. Please merge.

9

Changed 22 months ago by cyli

10

Changed 22 months ago by spiv

  • status changed from new to closed
  • resolution set to fixed

(In [34813]) Merge remove-deprecated-log-functions-5765: Removes deprecated functions from twisted.python.log.

Authors: thijs, spiv Reviewers: spiv, cyli Fixes: #5765

Removes startKeepingErrors, flushErrors, _flushErrors, ignoreErrors, _ignore, clearIgnores and _clearIgnores from twisted.python.log. They've been deprecated since Twisted 2.5.

Note: See TracTickets for help on using tickets.