Ticket #5713 enhancement new

Opened 22 months ago

Last modified 21 months ago

UnixSFTPFile hordes flag-conversion code

Reported by: magmatt Owned by: magmatt
Priority: normal Milestone:
Component: conch Keywords:
Cc: z3p Branch: branches/hoarders-conch-edition-5713
(diff, github, buildbot, log)
Author: magmatt Launchpad Bug:

Description

Why: conch.unix.UnixSFTPFile.init has code that converts SFTP file-opening flags to os-module flags (for use with os.open). I'd like to use that flag-making code, but don't want to use UnixSFTPFile. I think the code should be factored out.

What: My patch takes the flag-making code from init and puts it in a reusable module-level function.

Attachments

conchunixflag.patch Download (4.7 KB) - added by magmatt 22 months ago.
conch patch to factor out flag-making code

Change History

1

Changed 22 months ago by DefaultCC Plugin

  • cc z3p added

Changed 22 months ago by magmatt

conch patch to factor out flag-making code

2

Changed 21 months ago by itamarst

  • branch set to branches/hoarders-conch-edition-5713
  • branch_author set to itamarst

(In [34757]) Branching to 'hoarders-conch-edition-5713'

3

Changed 21 months ago by itamar

  • owner set to itamar
  • keywords review removed
  • branch_author changed from itamarst to magmatt

Looks good, will merge if I can get buildbot to pass.

4

Changed 21 months ago by itamar

Still needs to have test_unix deal with missing imports on Windows.

5

Changed 21 months ago by itamar

OK, fixed that hopefully, someday tests will run:  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/hoarders-conch-edition-5713

If they're good, it can be merged.

6

Changed 21 months ago by itamar

  • owner changed from itamar to magmatt

Sigh. Still failing in buildbot; it looks like it'd be pretty easy to fix, could you provide a patch against the branch?

Note: See TracTickets for help on using tickets.