Opened 2 years ago

Last modified 2 years ago

#5713 enhancement new

UnixSFTPFile hordes flag-conversion code

Reported by: magmatt Owned by: magmatt
Priority: normal Milestone:
Component: conch Keywords:
Cc: z3p Branch: branches/hoarders-conch-edition-5713
(diff, github, buildbot, log)
Author: magmatt Launchpad Bug:

Description

Why:
conch.unix.UnixSFTPFile.init has code that converts SFTP file-opening flags to os-module flags (for use with os.open). I'd like to use that flag-making code, but don't want to use UnixSFTPFile. I think the code should be factored out.

What:
My patch takes the flag-making code from init and puts it in a reusable module-level function.

Attachments (1)

conchunixflag.patch (4.7 KB) - added by magmatt 2 years ago.
conch patch to factor out flag-making code

Download all attachments as: .zip

Change History (7)

comment:1 Changed 2 years ago by DefaultCC Plugin

  • Cc z3p added

Changed 2 years ago by magmatt

conch patch to factor out flag-making code

comment:2 Changed 2 years ago by itamarst

  • Author set to itamarst
  • Branch set to branches/hoarders-conch-edition-5713

(In [34757]) Branching to 'hoarders-conch-edition-5713'

comment:3 Changed 2 years ago by itamar

  • Author changed from itamarst to magmatt
  • Keywords review removed
  • Owner set to itamar

Looks good, will merge if I can get buildbot to pass.

comment:4 Changed 2 years ago by itamar

Still needs to have test_unix deal with missing imports on Windows.

comment:5 Changed 2 years ago by itamar

OK, fixed that hopefully, someday tests will run: http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/hoarders-conch-edition-5713

If they're good, it can be merged.

comment:6 Changed 2 years ago by itamar

  • Owner changed from itamar to magmatt

Sigh. Still failing in buildbot; it looks like it'd be pretty easy to fix, could you provide a patch against the branch?

Note: See TracTickets for help on using tickets.