Opened 2 years ago

Last modified 2 years ago

#5712 enhancement new

Add stopTLS to twisted.internet._newtls.ConnectionMixin

Reported by: adiroiban Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: adi@… Branch:
Author: Launchpad Bug:

Description

t.i.i.ITLSTransport defined the startTLS but it would be nice if it will also define stopTLS.

As as start, support for stopTLS can be added in twisted.internet._newtls.ConnectionMixin

I am working at FTPS support for twisted.protocols.ftp and stopTLS is required for implementing FTP CCC command.

---

Please let me know if you think that this API is useful and I can try to implement it.

Any comments about how would you like it to be implemented is much appreciated.

Cheers,
Adi

Change History (3)

comment:1 Changed 2 years ago by exarkun

The functionality you're describing would certainly sometimes be useful, and Twisted should offer it more conveniently than it currently does. However, the API you described would not be my first choice. ITLSTransport was a mistake. Instead, we should work on resolving #3204 which will replace both ITLSTransport and provide the functionality described on this ticket.

comment:2 Changed 2 years ago by adiroiban

  • Cc adi@… added

Hi,

Sorry for the delay. Not sure why I have not received a notification email for you comment... maybe I need to explicitly add my email to CC.


Happy to see that ITLSTransport and the current API and code is going to change.

I am new to Twisted development and looking at #3204 and #5015 I don't know what can I do to help with implementing StopTLS support. Any advise for where to start is much appreciated.

Is this a duplicate of #5015 or #3204 or is not a duplicate at all?


Just for reference. In case someone want something right now, here is a quick and dirty patch:
https://github.com/chevah/deps/commit/2c686842a081d9b6a1ff5638eb02552d5a610011

comment:3 Changed 2 years ago by exarkun

It's not exactly a duplicate. If #5015 were resolved, though, I suspect you wouldn't care about this ticket anymore. #5015 describes a better solution to the use case presented here, so I'd rather spend any time working on that than on this.

Note: See TracTickets for help on using tickets.