Opened 6 years ago

Closed 6 years ago

#5687 task closed fixed (fixed)

Release Twisted 12.1

Reported by: therve Owned by: therve
Priority: normal Milestone:
Component: release management Keywords:
Cc: radix Branch: branches/releases/release-12.1.0-5687
branch-diff, diff-cov, branch-cov, buildbot
Author: therve

Description

Lots of stuff happened during the past months, so let's release them. This is going to be last release supporting Python 2.5, too.

Change History (5)

comment:1 Changed 6 years ago by DefaultCC Plugin

Cc: radix added

comment:2 Changed 6 years ago by therve

Branch: branches/releases/release-12.1.0-5687

comment:3 Changed 6 years ago by therve

Author: therve
Keywords: review added
Owner: therve deleted

Please review!

comment:4 Changed 6 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to therve

Thanks for taking on another release! This looks good except for a couple minor points:

  1. There's a typo in one of the twisted/words/topfiles/NEWS fragments: thread instead of threat. The typo is duplicated in the overall NEWS file too I guess.
  2. twisted/topfiles/5653.misc still exists. I suspect this is due to a bug in subversion which caused it to not exist in your working copy of Twisted trunk, thus causing it to not exist in the branch you created, thus causing it to not be affected by an "svn rm *.misc" (or similar) command.

The rest looks good to me, you should merge after these two things are fixed.

comment:5 Changed 6 years ago by therve

Resolution: fixed
Status: newclosed

Merged in r34509.

Note: See TracTickets for help on using tickets.