Ticket #5685 enhancement new

Opened 12 months ago

Last modified 8 months ago

Outdated SMTP Client Tutorial

Reported by: argonemyth Owned by: argonemyth
Priority: lowest Milestone:
Component: mail Keywords: documentation
Cc: jesstess, fei@…, thijs Branch:
Author: Launchpad Bug:

Description

The  tutorial is nice. I like the error-prone to the exception-free approach, but the current twistd no longer throws those exceptions. Running smtpclient-1.tac to smtpclient-10.tac, you would get similar output! So, a re-write is needed! :)

Attachments

5685-SMTPClient_Tutorial-20120724.patch Download (17.9 KB) - added by argonemyth 10 months ago.

Change History

1

Changed 10 months ago by argonemyth

  • owner argonemyth deleted
  • cc fei@… added
  • type changed from defect to enhancement
  • keywords review added
  • priority changed from normal to lowest

Hi,

I was totally wrong about the twistd's behaviour described above!!! I must have ran the tac files without checking what's inside, and I didn't have a SMTP server on the localhost. So, the only change I made to the tutorial itself is to add the following sentences in the SMTP Client 3 section:

If you don't have a local SMTP server, you can replace localhost with other SMTP servers (like ASPMX.L.GOOGLE.COM). The rest of the tutorial will require a working SMTP server.

I also updated the output with Twisted version 12.1.0 and removed some trailing whitespace.

It's ok if you don't use the patch, but still, running all the examples and updating the output did took quite some time, so I would be glad if you guys use the patch!!

Thanks!

Changed 10 months ago by argonemyth

2

Changed 8 months ago by thijs

  • keywords review removed
  • owner set to argonemyth
  • cc thijs added
  1. The output almost matches the actual example output. In the tutorial I see:
    18:55 EST [-] Log opened.
    
    Running it locally shows the full timestamp is missing:
    2012-09-13 14:51:18+0200 [-] Log opened.
    
  2. When running twistd -ny smtpclient-3.tac it outputs the following, which differs from the output you added, why is that?:
    2012-09-13 14:54:42+0200 [-] Log opened.
    2012-09-13 14:54:42+0200 [-] using set_wakeup_fd
    2012-09-13 14:54:42+0200 [-] twistd 12.1.0+r35620 (/usr/bin/python 2.7.3) starting up.
    2012-09-13 14:54:42+0200 [-] reactor class: twisted.internet.epollreactor.EPollReactor.
    2012-09-13 14:54:42+0200 [-] Starting factory <twisted.internet.protocol.ClientFactory instance at 0x7fe356107ea8>
    2012-09-13 14:54:42+0200 [Uninitialized] Stopping factory <twisted.internet.protocol.ClientFactory instance at 0x7fe356107ea8>
    ^C2012-09-13 14:54:48+0200 [-] Received SIGINT, shutting down.
    2012-09-13 14:54:48+0200 [-] Main loop terminated.
    2012-09-13 14:54:48+0200 [-] Server Shut Down.
    
  3. Same for smtpclient-5.tac, I don't see the traceback.

In general:

  1. A .misc newsfile is missing
  2. Can you put this in a branch so we can test it with buildbot

Thanks!

Note: See TracTickets for help on using tickets.