Ticket #5680 defect new
test_timelyProcessExited is fragile and may not catch actual problems
| Reported by: | itamar | Owned by: | itamar |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | core | Keywords: | |
| Cc: | Branch: | branches/process-test-5680 | |
| Author: | itamar | Launchpad Bug: |
Description
JP pointed out that test_timelyProcessExited in twisted.internet.test_process may fail without us noticing:
The problem is that the timeout support in runReactor is based on the IReactorTime implementation of the reactor it is running. It's quite likely that if the reactor is broken, instead of failing:
- the child will exit
- the reactor will not process the signal right away
- the timeout will elapse
- the reactor will wake up
- the signal will be processed, calling processEnded
- reactor.stop() will be called
- runReactor will notice the reactor was stopped and not raise a timeout exception
- the test will pass
Change History
Note: See
TracTickets for help on using
tickets.
