Opened 2 years ago

Closed 2 years ago

#5674 defect closed fixed (fixed)

Old quotes are a bad representation of current culture

Reported by: itamar Owned by: itamar
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/old-quotes-5674-2
(diff, github, buildbot, log)
Author: itamarst, itamar Launchpad Bug:

Description

The historical quote file is currently in ascending order, starting with the oldest quotes. Some of the quotes (though nothing past 2006 AFAICT) are offensive, e.g. sexist, and it is not clear to the casual reader that these are no longer reflective of our culture.

As a solution I propose splitting up the file, changing the order to be descending (from new to old), and adding a note/apology to that effect.

Change History (10)

comment:1 Changed 2 years ago by glyph

I like the idea.

My preference would be to divide up the quote file by release version, since new versions will be divided up that way, rather than by year, which is arbitrary and doesn't really correspond to any milestones in Twisted development or history.

comment:2 Changed 2 years ago by itamarst

  • Author set to itamarst
  • Branch set to branches/old-quotes-5674

(In [34365]) Branching to 'old-quotes-5674'

comment:3 Changed 2 years ago by itamar

I suppose splitting by release makes changing the order less necessary, since each file will cover a smaller timespan. So maybe I'll just do that.

comment:4 Changed 2 years ago by itamar

  • Author changed from itamarst to itamar
  • Keywords review added
  • Owner changed from itamar to glyph

I split up quotes by release, added an explanation and apology, and excluded doc/historic/ from the release tarball. No reason to include either old quotes or talks from 2002 in our every release tarball; if anyone cares they can do a checkout or use trac to read it.

http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/old-quotes-5674

comment:5 Changed 2 years ago by exarkun

  • Keywords review removed
  • Owner changed from glyph to itamar

Looks pretty good to me. My only thought is that we might want to have some more developers sign the README.

comment:6 follow-up: Changed 2 years ago by itamar

Shall I add you, JP? How about Glyph? (It's also easy to add one's name later, since really historic/ isn't under code review process either).

comment:7 in reply to: ↑ 6 Changed 2 years ago by glyph

Replying to itamar:

Shall I add you, JP? How about Glyph? (It's also easy to add one's name later, since really historic/ isn't under code review process either).

Go ahead and add me. And let's get this over with :).

comment:8 Changed 2 years ago by exarkun

(In [34646]) Pronoun adjustment and additional signatures

refs #5674

comment:9 Changed 2 years ago by itamarst

  • Author changed from itamar to itamarst, itamar
  • Branch changed from branches/old-quotes-5674 to branches/old-quotes-5674-2

(In [35153]) Branching to 'old-quotes-5674-2'

comment:10 Changed 2 years ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [35155]) Merge old-quotes-5674-2: Deal with unfortunate old quotes.

Author: itamar
Review: exarkun
Fixes: #5674
Deal with old quotes: split up by release, added apology for the bad ones. Additionally, doc/historic/ is no longer packaged in the tarball.

Note: See TracTickets for help on using tickets.