twisted.names.cache.CacheResolver never times out data it is initialized with

[itamar]

The CacheResolver internal cache can be initialized with beginning values. Unlike cache entries added later, these initial entries will never be timed out or removed.

[acidfoo]

Changed the constructor to pass the initial entries through cacheResult instead of just assigning the dictionary.

The original unit test (test_lookup) passes in an empty record ([], [], []) which would originally crash the cacheResult function. I wasn't sure if I could just remove the old test, so I made it assume a TTL of 0 when there are no entries in the payload.

[itamar]

Thanks for the patch, looks good, with two minor issues:

1. Extra whitespace at end of lines.
2. A comment explaining why time elapsed of 40 is good enough to expire the record in the new test would be helpful.

I didn't realise the interface involves passing in absolute timestamps, which is pretty terrible. So I also suggest deprecating passing in cache to the constructor. That can be done in a separate ticket, though. So unless I hear from you this weekend with new patch, I will just commit this one doing the above minor tweaks myself, and open a new ticket for the deprecation.

[itamarst]

(In [34351]) Branching to 'cacheresolver-init-5638'

[itamarst]

(In [34359]) Merge cacheresolver-init-5638: Entries added to CacheResolver's init are now timed out.

Author: acidfoo Review: itamar Fixes: #5638

Fix issue where entries added via CacheResolver's constructor were never timed out.