Opened 6 years ago

Closed 6 years ago

#5622 enhancement closed duplicate (duplicate)

Refactor TCPClientTestsBuilder and TCP6ClientTestsBuilder to make their endpoint factories re-usable for other test cases

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: core Keywords: tests
Cc: Branch: branches/tcp-endpoints-tests-refactor-5622
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

These two ReactorBuilder subclasses also define useful functionality for other test cases, but since they inherit test methods from another TestCase mixin, that functionality can't be re-used without also inheriting those test methods (which at best will cause tests to be run repeatedly, at worst will add unwanted failing tests to another case).

Change History (4)

comment:1 Changed 6 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/tcp-endpoints-tests-refactor-5622

(In [34131]) Branching to 'tcp-endpoints-tests-refactor-5622'

comment:2 Changed 6 years ago by Jean-Paul Calderone

Keywords: review added

Simple refactoring, no intended change in behavior, build results (hope they look good).

comment:3 Changed 6 years ago by Itamar Turner-Trauring

A quick glance suggests this a subset of the functionality in #5392 (which is still up for review). If that is correct, can we just get #5392 in instead?

comment:4 Changed 6 years ago by Jean-Paul Calderone

Keywords: review removed
Resolution: duplicate
Status: newclosed

Superceded by #5392.

Note: See TracTickets for help on using tickets.