_cbGetPublicKey method of SSHUserAuthClient heck of swallows exceptions

[teratorn]

This code needs to log the Failure.

[exarkun]

All conch tickets are not easy by default. Also, please fix the summary and description of this ticket.

[teratorn]

The method, if passed in a failure (it's a target of a Deferred.addBoth call), needs to log it before proceeding to fail the authentication request. I don't know how to make the summary more clear - it swallows at exception it (in my opinion) shouldn't. And I don't know how to change ticket descriptions.

Anyone that looks at the method in question would be able to understand exactly that this ticket is about.

But if you actually have some constructive criticism to give, please do so - "fix it" is completely unhelpful.