Ticket #5564 task closed fixed

Opened 14 months ago

Last modified 3 months ago

Remove deprecated API in t.names.root

Reported by: thijs Owned by: tom.prince
Priority: normal Milestone:
Component: names Keywords: easy
Cc: thijs Branch: branches/names-root-5564
Author: piffey Launchpad Bug:

Description

The following were deprecated in 10.0 (r27740/#970) and can be removed:

  • retry
  • Resolver.discoveredAuthority
  • lookupNameservers
  • lookupAddress
  • extractAuthority
  • discoverAuthority

Attachments

5564.patch Download (12.5 KB) - added by piffey 14 months ago.
5564.removal Download (0.7 KB) - added by piffey 14 months ago.
Must have forgotten to grab the new file with svn diff. Whoops!
5564.removal-2 Download (197 bytes) - added by piffey 14 months ago.
Revision to cut down on repetition.

Change History

Changed 14 months ago by piffey

1

follow-up: ↓ 3   Changed 14 months ago by piffey

  • keywords easy, review added; easy removed

First time contributing, followed the model of other tickets and hope everything is proper. Added news file already as well.

2

  Changed 14 months ago by thijs

  • branch set to branches/names-root-5564
  • branch_author set to thijs

(In [33962]) Branching to 'names-root-5564'

3

in reply to: ↑ 1   Changed 14 months ago by thijs

  • owner set to piffey
  • keywords easy added; easy, review removed
  • branch_author changed from thijs to piffey

Replying to piffey:

First time contributing, followed the model of other tickets and hope everything is proper. Added news file already as well.

Thanks. All looks good but the news file wasn't included in the patch. Can you attach it here?

Changed 14 months ago by piffey

Must have forgotten to grab the new file with svn diff. Whoops!

4

follow-up: ↓ 6   Changed 14 months ago by exarkun

Thanks. The news file doesn't need to mention the removed unit tests, only the removed public APIs. Also, if you can factor out the duplicate text in a way that doesn't make it sound awkward, that'd be great.

To future reviewers, though this looks pretty good and is probably just about in shape to merge to trunk, please do not merge to trunk yet.

Changed 14 months ago by piffey

Revision to cut down on repetition.

5

  Changed 14 months ago by itamar

  • keywords review added

6

in reply to: ↑ 4   Changed 14 months ago by thijs

  • owner changed from piffey to exarkun

Replying to exarkun:

To future reviewers, though this looks pretty good and is probably just about in shape to merge to trunk, please do not merge to trunk yet.

I added the news file in r34122. Assigning to exarkun for review based on his comment 4.

7

follow-up: ↓ 8   Changed 14 months ago by exarkun

  • keywords review removed

Don't think there's anything left to review here.

8

in reply to: ↑ 7   Changed 8 months ago by thijs

  • owner changed from exarkun to thijs
  • status changed from new to assigned

Replying to exarkun:

Don't think there's anything left to review here.

Alright, I'll merge it then.

9

follow-up: ↓ 10   Changed 8 months ago by exarkun

  • status changed from assigned to new
  • owner changed from thijs to exarkun

Please don't. There's no reason to rush to remove deprecated things. We should leave them *as long as possible*.

10

in reply to: ↑ 9   Changed 8 months ago by thijs

Replying to exarkun:

Please don't. There's no reason to rush to remove deprecated things. We should leave them *as long as possible*.

Thanks for the clarification, comment 7 got me confused.

11

  Changed 3 months ago by tom.prince

I'm working on #6044, and so need to change all uses of deferredGenerator. discoverAuthority uses it, so this ticket can probably land now.

12

  Changed 3 months ago by exarkun

  • owner changed from exarkun to tom.prince

That's reasonable.

13

  Changed 3 months ago by tomprince

  • status changed from new to closed
  • resolution set to fixed

(In [37287]) Merge names-root-5564: Remove deprecated API in twisted.names.root.

Author: piffey Reviewers: thijs Fixes: #5564

The following were deprecated in 10.0 (r27740/#970) and can be removed:

  • retry
  • Resolver.discoveredAuthority
  • lookupNameservers
  • lookupAddress
  • extractAuthority
  • discoverAuthority
Note: See TracTickets for help on using tickets.