Opened 3 years ago

Closed 2 years ago

#5554 task closed fixed (fixed)

t.trial.runner.DocTestCase is deprecated and should be removed

Reported by: rockstar Owned by: spiv
Priority: normal Milestone:
Component: core Keywords:
Cc: moijes12@…, thijs Branch: branches/remove-doctestcase-5554
(diff, github, buildbot, log)
Author: moijes12 Launchpad Bug:

Description

While fixing ticket #5386, jesstess mentioned that the removal of DocTestCase should be its own ticket. This. This is that ticket.

Attachments (2)

5554.patch (1.2 KB) - added by moijes12 2 years ago.
5554.2.patch (1.2 KB) - added by moijes12 2 years ago.
Patch updated with the corrections to the .removal file.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 3 years ago by bartekci

  • Owner changed from rockstar to bartekci
  • Status changed from new to assigned

This was removed while working on #5387. In Changeset [33807]

Changed 2 years ago by moijes12

comment:2 Changed 2 years ago by moijes12

  • Cc moijes12@… added
  • Keywords review added
  • Owner bartekci deleted
  • Status changed from assigned to new

I've attached the patch. I don't know about the below entries though I have a feeling they shouldn't matter or they aren't related.

twisted/trial/runner.py:580: # Work around Python issue2604: DocTestCase.tearDown clobbers globs
twisted/trial/unittest.py:1498: methods. That is L{pyunit.FunctionTestCase} and L{pyunit.DocTestCase}.
twisted/trial/unittest.py:1538:_docTestCase = getattr(doctest, 'DocTestCase', None)

comment:3 Changed 2 years ago by thijs

  • Cc thijs added
  • Keywords review removed
  • Owner set to moijes12
  • Type changed from enhancement to task

Thanks. Can you create a branch for this patch and run it on the buildslaves using force-builds.py? The .removal file should also mention when it was deprecated (Twisted 8.0).

comment:4 Changed 2 years ago by moijes12

Hi

I don't know how to create a branch and I don't really think I'll be able to do it as I don't have commit rights ? But I'll do the other change to the .removal file and upload it.

comment:5 Changed 2 years ago by thijs

Oh my bad, I thought you had commit rights. Someone else can apply the patch and/or put it in a branch in that case. Thanks.

Changed 2 years ago by moijes12

Patch updated with the corrections to the .removal file.

comment:6 Changed 2 years ago by moijes12

  • Keywords review added
  • Owner moijes12 deleted

comment:7 Changed 2 years ago by thijs

(In [34644]) apply 5554.2.patch, refs #5554

comment:8 Changed 2 years ago by thijs

  • Author set to moijes12
  • Branch set to branches/remove-doctestcase-5554

comment:9 Changed 2 years ago by spiv

  • Keywords review removed
  • Owner set to spiv
  • Status changed from new to assigned

KILL IT KILL IT KILL IT WITH FIRE.

Er, what I meant to say: looks good to me. I'll submit it.

comment:10 Changed 2 years ago by spiv

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [34802]) Merge remove-doctestcase-5554: Remove twisted.trial.runner.DocTestCase.

Author: moijes12
Reviewer: thijs, spiv
Fixes: #5554

Removes twisted.trial.runner.DocTestCase, which has been deprecated since
Twisted 8.0.

Note: See TracTickets for help on using tickets.