Ticket #5554 task closed fixed

Opened 14 months ago

Last modified 10 months ago

t.trial.runner.DocTestCase is deprecated and should be removed

Reported by: rockstar Owned by: spiv
Priority: normal Milestone:
Component: core Keywords:
Cc: moijes12@…, thijs Branch: branches/remove-doctestcase-5554
Author: moijes12 Launchpad Bug:

Description

While fixing ticket #5386, jesstess mentioned that the removal of DocTestCase should be its own ticket. This. This is that ticket.

Attachments

5554.patch Download (1.2 KB) - added by moijes12 11 months ago.
5554.2.patch Download (1.2 KB) - added by moijes12 11 months ago.
Patch updated with the corrections to the .removal file.

Change History

1

Changed 14 months ago by bartekci

  • owner changed from rockstar to bartekci
  • status changed from new to assigned

This was removed while working on #5387. In Changeset [33807]

Changed 11 months ago by moijes12

2

Changed 11 months ago by moijes12

  • owner bartekci deleted
  • cc moijes12@… added
  • status changed from assigned to new
  • keywords review added

I've attached the patch. I don't know about the below entries though I have a feeling they shouldn't matter or they aren't related.
twisted/trial/runner.py:580: # Work around Python issue2604: DocTestCase.tearDown clobbers globs
twisted/trial/unittest.py:1498: methods. That is L{pyunit.FunctionTestCase} and L{pyunit.DocTestCase}.
twisted/trial/unittest.py:1538:_docTestCase = getattr(doctest, 'DocTestCase', None)

3

Changed 11 months ago by thijs

  • owner set to moijes12
  • cc thijs added
  • type changed from enhancement to task
  • keywords review removed

Thanks. Can you create a branch for this patch and run it on the buildslaves using force-builds.py? The .removal file should also mention when it was deprecated (Twisted 8.0).

4

Changed 11 months ago by moijes12

Hi

I don't know how to create a branch and I don't really think I'll be able to do it as I don't have commit rights ? But I'll do the other change to the .removal file and upload it.

5

Changed 11 months ago by thijs

Oh my bad, I thought you had commit rights. Someone else can apply the patch and/or put it in a branch in that case. Thanks.

Changed 11 months ago by moijes12

Patch updated with the corrections to the .removal file.

6

Changed 11 months ago by moijes12

  • owner moijes12 deleted
  • keywords review added

7

Changed 11 months ago by thijs

(In [34644]) apply 5554.2.patch, refs #5554

8

Changed 11 months ago by thijs

  • branch set to branches/remove-doctestcase-5554
  • branch_author set to moijes12

 Build results.

9

Changed 10 months ago by spiv

  • keywords review removed
  • status changed from new to assigned
  • owner set to spiv

KILL IT KILL IT KILL IT WITH FIRE.

Er, what I meant to say: looks good to me. I'll submit it.

10

Changed 10 months ago by spiv

  • status changed from assigned to closed
  • resolution set to fixed

(In [34802]) Merge remove-doctestcase-5554: Remove twisted.trial.runner.DocTestCase.

Author: moijes12 Reviewer: thijs, spiv Fixes: #5554

Removes twisted.trial.runner.DocTestCase, which has been deprecated since Twisted 8.0.

Note: See TracTickets for help on using tickets.