If gi can't be imported, gtk2 reactor still fails (and vice versa)
|Reported by:||itamar||Owned by:||itamar|
branch-diff, diff-cov, branch-cov, buildbot
#4558 made it impossible to import twisted.internet.gtk2reactor if sys.modules contains a "gi" key. This seems to overlook the fact that even a *failed* import of the gi module adds such a key to that dictionary. Since the test suite tries to test gireactor, there will always be such a key, so gtk2reactor can never be imported by the test suite. The same issue would operate, only in reverse, if gtk2reactor was imported first.
Change History (11)
comment:10 Changed 5 years ago by jesstess
- Keywords review removed
- Owner changed from jesstess to itamar