Ticket #5473 task closed fixed

Opened 16 months ago

Last modified 16 months ago

Remove deprecated t.python.threadpool.ThreadSafeList

Reported by: thijs Owned by: thijs
Priority: lowest Milestone:
Component: core Keywords:
Cc: thijs, jesstess Branch: branches/del-threadsafelist-5473
Author: thijs Launchpad Bug:

Description

twisted.python.threadpool.ThreadSafeList is deprecated in r28995 (#3725) and can be removed in a next release.

Change History

1

  Changed 16 months ago by thijs

  • branch set to branches/del-threadsafelist-5473
  • branch_author set to thijs

(In [33518]) Branching to 'del-threadsafelist-5473'

2

  Changed 16 months ago by thijs

(In [33519]) remove ThreadSafeList and apply coding standard fixes. refs #5473

3

  Changed 16 months ago by thijs

  • keywords review added

4

  Changed 16 months ago by jesstess

  • owner set to jesstess

5

follow-up: ↓ 7   Changed 16 months ago by jesstess

  • cc jesstess added
  • owner changed from jesstess to thijs
  • keywords review removed

Thanks for working on this, thijs.

The  build results show a failure in the documentation builder:

twisted.python.threadpool.ThreadPool.callInThreadWithCallback: invalid ref to Deferred

There are also a couple of places in callInThreadWithCallback which could use C{} markup to onResult.

Once those things are fixed, I think this is ready to merge!

6

  Changed 16 months ago by thijs

(In [33536]) address review comments, refs #5473

7

in reply to: ↑ 5   Changed 16 months ago by thijs

  • status changed from new to assigned

Replying to jesstess:

Thanks for working on this, thijs. The  build results show a failure in the documentation builder: twisted.python.threadpool.ThreadPool.callInThreadWithCallback: invalid ref to Deferred There are also a couple of places in callInThreadWithCallback which could use C{} markup to onResult. Once those things are fixed, I think this is ready to merge!

Thanks for the review.  Build results are ok now, merging the branch.

8

  Changed 16 months ago by thijs

  • status changed from assigned to closed
  • resolution set to fixed

(In [33537]) Merge del-threadsafelist-5473: Removed t.p.threadpool.ThreadSafeList (deprecated in 10.1), an internal implementation detail of support for Jython 2.1, which is now obsolete.

Author: thijs Reviewer: jesstess Fixes: #5473

Note: See TracTickets for help on using tickets.