Opened 2 years ago

Closed 2 years ago

#5473 task closed fixed (fixed)

Remove deprecated t.python.threadpool.ThreadSafeList

Reported by: thijs Owned by: thijs
Priority: lowest Milestone:
Component: core Keywords:
Cc: thijs, jesstess Branch: branches/del-threadsafelist-5473
(diff, github, buildbot, log)
Author: thijs Launchpad Bug:

Description

twisted.python.threadpool.ThreadSafeList is deprecated in r28995 (#3725) and can be removed in a next release.

Change History (8)

comment:1 Changed 2 years ago by thijs

  • Author set to thijs
  • Branch set to branches/del-threadsafelist-5473

(In [33518]) Branching to 'del-threadsafelist-5473'

comment:2 Changed 2 years ago by thijs

(In [33519]) remove ThreadSafeList and apply coding standard fixes. refs #5473

comment:3 Changed 2 years ago by thijs

  • Keywords review added

comment:4 Changed 2 years ago by jesstess

  • Owner set to jesstess

comment:5 follow-up: Changed 2 years ago by jesstess

  • Cc jesstess added
  • Keywords review removed
  • Owner changed from jesstess to thijs

Thanks for working on this, thijs.

The build results show a failure in the documentation builder:

twisted.python.threadpool.ThreadPool.callInThreadWithCallback: invalid ref to Deferred

There are also a couple of places in callInThreadWithCallback which could use C{} markup to onResult.

Once those things are fixed, I think this is ready to merge!

comment:6 Changed 2 years ago by thijs

(In [33536]) address review comments, refs #5473

comment:7 in reply to: ↑ 5 Changed 2 years ago by thijs

  • Status changed from new to assigned

Replying to jesstess:

Thanks for working on this, thijs.

The build results show a failure in the documentation builder:

twisted.python.threadpool.ThreadPool.callInThreadWithCallback: invalid ref to Deferred

There are also a couple of places in callInThreadWithCallback which could use C{} markup to onResult.

Once those things are fixed, I think this is ready to merge!

Thanks for the review. Build results are ok now, merging the branch.

comment:8 Changed 2 years ago by thijs

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [33537]) Merge del-threadsafelist-5473: Removed t.p.threadpool.ThreadSafeList (deprecated in 10.1), an internal implementation detail of support for Jython 2.1, which is now obsolete.

Author: thijs
Reviewer: jesstess
Fixes: #5473

Note: See TracTickets for help on using tickets.