Changes between and of Initial VersionVersion 2Ticket #5455


Ignore:
Timestamp:
01/19/2012 07:12:49 AM (3 years ago)
Author:
exarkun
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5455

    • Property Keywords review added; REVIEW removed
  • Ticket #5455 – Description

    initial v2  
    11This patch, applied to twisted 11.1.0 after the patch in 5454, does the following: 
    22 
    3 1. Causes FileAuthority to search for a name suffixed with a trailing period if it doesn't find the name in records. The reason for this is that if records are created from a bind file, they may be created with a trailing dot, but FileAuthority will never find them since it will never search for a name with a trailing dot. 
    4  
    5 2. Allows a DNS Secondary server to use a primary DNS server that is serving on a port other than port 53.  
    6  
    7 3. Fixes problems with parsing a bind format zone file. The previous parser was simply wrong. It regarded leading whitespace as irrelevant, when in fact leading whitespace is significant. leading whitespace indicates the absence of a name. 
    8   
    9 4. Fixes a bug that others have noticed with connectionLost getting called on UDP protocol. This bug happens when a DNS query issued over UDP is retried on TCP. Given no further DNS activity, 30 seconds after the TCP query completes, connectionLost is called on the UDP protcol and, absent this method, raises an exception. 
     3 1. Causes FileAuthority to search for a name suffixed with a trailing period if it doesn't find the name in records. The reason for this is that if records are created from a bind file, they may be created with a trailing dot, but FileAuthority will never find them since it will never search for a name with a trailing dot. 
     4 1. Allows a DNS Secondary server to use a primary DNS server that is serving on a port other than port 53.  
     5 1. Fixes problems with parsing a bind format zone file. The previous parser was simply wrong. It regarded leading whitespace as irrelevant, when in fact leading whitespace is significant. leading whitespace indicates the absence of a name. 
     6 1. Fixes a bug that others have noticed with connectionLost getting called on UDP protocol. This bug happens when a DNS query issued over UDP is retried on TCP. Given no further DNS activity, 30 seconds after the TCP query completes, connectionLost is called on the UDP protcol and, absent this method, raises an exception.