Opened 3 years ago

Closed 3 years ago

#5453 enhancement closed invalid (invalid)

Add EDNS0, DNSSEC record types to twisted.names

Reported by: BobNovas Owned by:
Priority: normal Milestone:
Component: names Keywords: review, DNS, EDNS0, DNSSEC, Serial Number Arithmetic
Cc: Branch:
Author: Bob Novas Launchpad Bug:

Description

This patch, applied to twisted 11.1.0, adds the following record types to dns.py: OPTHeader, Record_OPT, Record_RRSIG, Record_DS, Record_DNSKEY, Record_NSEC, Record_NSEC3PARAM, Record_NSEC3. It also adds a serial number arithmetic module, used to compare DNSSEC dates. And finally, it adds tests for the new record types and classes to test_dns.

This patch is the first patch of a number of patches that add EDNS0 and DNSSEC capability to twisted names. This patch simply adds the new record types (and tests) with no behavioral changes.

Attachments (3)

add-edn0-dnssec-record-types-01.patch (53.6 KB) - added by BobNovas 3 years ago.
Adds EDNS0 and DNSSEC record types to twisted.names, includes unit tests.
add-ends0-dnssec-record-types-01a.patch (52.8 KB) - added by BobNovas 3 years ago.
replaces previous patch
add-ends0-dnssec-record-types-01b.patch (57.0 KB) - added by BobNovas 3 years ago.
whoops. Use this file in place of 1a. I forgot to add the new ser_num_arith.py file to svn

Download all attachments as: .zip

Change History (8)

Changed 3 years ago by BobNovas

Adds EDNS0 and DNSSEC record types to twisted.names, includes unit tests.

comment:1 Changed 3 years ago by exarkun

  • Keywords review added; REVIEW removed

comment:2 Changed 3 years ago by MostAwesomeDude

This isn't a full review, because I am not familiar with DNSSEC.

serialNumberArithmetic.py isn't a super-fun name for a file. There appears to be an informal bit of testing going on at the end of that module; could that be moved to a set of real unit tests?

Most of the code appears decent, but this is a *massive* patch and I'd really like somebody else to look at it. (Also those tests, please!)

comment:3 Changed 3 years ago by BobNovas

  • Owner set to BobNovas
  • Status changed from new to assigned

I'll address MostAwesomeDude's comments and resubmit.

Changed 3 years ago by BobNovas

replaces previous patch

comment:4 Changed 3 years ago by BobNovas

  • Owner BobNovas deleted
  • Status changed from assigned to new

submitted a new patch file - add-ends0-dnssec-record-types-01a.patch.

This patch file is relative to the "current" trunk. I renamed the file serialNumberArithmetic.py to ser_num_arith.py and added a separate test_ser_num_arith.py with separate tests for various serial number arithmetic functions.

I found a bug in the previous patch file in that it would not have compiled without the change to common to add class DnssecConfig().

I also refreshed the patch so that it's against the current code base.

Bob

Changed 3 years ago by BobNovas

whoops. Use this file in place of 1a. I forgot to add the new ser_num_arith.py file to svn

comment:5 Changed 3 years ago by BobNovas

  • Resolution set to invalid
  • Status changed from new to closed

I combined this work with 5454 since it really shouldn't have been separated. So it's really been overtaken by events. I marked it invalid.

Note: See TracTickets for help on using tickets.