Opened 3 years ago

Last modified 3 years ago

#5410 enhancement new

Avoid using space in subproject distutils names

Reported by: bersace Owned by: bersace
Priority: normal Milestone:
Component: release management Keywords: setuptools subprojects
Cc: radix Branch:
Author: Launchpad Bug:

Description

Hi,

Twisted subprojects provides setup.py with name like Twisted Core and archive TwistedCore_11.1.0.tar.bz2.

This break dependencies in regular distutils setup.py and pip usage.

If you use requires=['Twisted Core'], setup.py just fail with error in … setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers

If you use requires=['TwistedCore'], pip will find the archive in a local pypi repository. But it will be installed in Twisted_Core-11.1.0 and with Name: Twisted-Core in the installed EGG-INFO.

Can you rename subprojects to use hyphen instead of space in their name ? I couldn't find the code setting the name= keyword args for setup() (searched twisted.python.dist and setup.py).

Regards,
Étienne BERSAC

Change History (3)

comment:1 Changed 3 years ago by DefaultCC Plugin

  • Cc radix added

comment:2 Changed 3 years ago by exarkun

  • Owner set to bersace

Hi Étienne, thanks for your interest in Twisted.

What is the motivation for not considering this a bug in pip? Perhaps Twisted should work around the problem by renaming some packages, but PyPI happily accepts these packages. As a PyPI consumer, pip should be able to deal with exactly the same thing. Has this bug been reported upstream? What do the pip maintainers think?

comment:3 Changed 3 years ago by exarkun

Apparently this was reported upstream several months ago, <https://github.com/pypa/pip/issues/307>. I'm not really sure how to interpret the last comment, but it sounds like maybe pnasrat thinks it's a legitimate pip bug. As such, I'm inclined to close this as wontfix and let pip deal with it. Thoughts?

Note: See TracTickets for help on using tickets.