Opened 13 years ago

Last modified 13 years ago

#538 enhancement closed fixed (fixed)

Lore Slides: more flexible behaviour for class='next' in <a> and <span>, remove element when link is invalid

Reported by: Nafai Owned by: spiv
Priority: normal Milestone:
Component: lore Keywords:
Cc: Nafai, spiv Branch:
Author:

Description


Attachments (1)

lore-slides.patch (1.2 KB) - added by spiv 13 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 13 years ago by Nafai

Various snippets of the IRC conversation:
<spiv> Nafai: Hmm, part of the problem is you *don't* want to list the title of
the prev/next slides in the hyperlink?
<spiv> Maybe I should change it so that <a class="next"> indicates that the href
attr should be set, but <span class="next"> indicates the title should be
appended to the element's text.
<spiv> Then you could do what you want, and the old behaviour would be done via
nesting, e.g. <a class="next"><span class="next">Next: </span></a>

<spiv> The no-tooltip would be achievable via deleting the element entirely in
the case that there's no prev (or next).

Changed 13 years ago by spiv

Attachment: lore-slides.patch added

comment:2 Changed 13 years ago by spiv

Here's a patch that should do this (support <a class="next"><span
class="next">Next: </span></a>).

Looking at the code, it appears that it should already delete an element with
class="next" if there's no next slide (and similarly for class="previous").

I guess this stuff needs test cases :/

Let me know how this goes.

comment:3 Changed 13 years ago by Nafai

Patch seems to work fine and accomplish what I need.

comment:4 Changed 13 years ago by spiv

Ok, great.  I've applied the patch.
Note: See TracTickets for help on using tickets.