Opened 5 years ago

Closed 5 years ago

#5371 enhancement closed fixed (fixed)

In the developer guide, forbid new global reactor unit tests

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: core Keywords: documentation
Cc: Branch: branches/no-global-reactor-testing-5371
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

On the mailing list, <http://twistedmatrix.com/pipermail/twisted-python/2011-November/024732.html>, proposed the idea that we shouldn't be adding new unit tests to Twisted which use the global reactor. No disagreement in the resulting discussion.

Change History (8)

comment:1 Changed 5 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/no-global-reactor-testing-5371

(In [33092]) Branching to 'no-global-reactor-testing-5371'

comment:2 Changed 5 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

comment:3 Changed 5 years ago by Andrés Gasson

Resolution: fixed
Status: newclosed

Documentation looks good and understandable. no formatiing errors nor spellling mistakes in browser. Makes sense to me.

comment:4 Changed 5 years ago by Itamar Turner-Trauring

Resolution: fixed
Status: closedreopened

When reviewing branches, if you're done with the review you should remove the "review" keyword and reassign back to author, not close the ticket.

comment:5 Changed 5 years ago by Thijs Triemstra

Keywords: review removed
Owner: set to Jean-Paul Calderone
Status: reopenednew

Looks good to merge.

comment:6 Changed 5 years ago by Itamar Turner-Trauring

There's a spelling mistake: "unweildy" instead of "unwieldy". Also maybe change the title from "Tips" to "Guidelines".

comment:7 Changed 5 years ago by Jean-Paul Calderone

(In [33115]) incorporate itamar's suggested improvements

refs #5371

comment:8 Changed 5 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [33116]) Merge no-global-reactor-testing-5371

Author: exarkun Reviewer: frap, thijs, itamar Fixes: #5371

Codify the proscription on global reactor use in unit tests.

Note: See TracTickets for help on using tickets.