Ticket #5371 enhancement closed fixed

Opened 7 months ago

Last modified 6 months ago

In the developer guide, forbid new global reactor unit tests

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone:
Component: core Keywords: documentation
Cc: Branch: branches/no-global-reactor-testing-5371
Author: exarkun Launchpad Bug:

Description

On the mailing list, < http://twistedmatrix.com/pipermail/twisted-python/2011-November/024732.html>, proposed the idea that we shouldn't be adding new unit tests to Twisted which use the global reactor. No disagreement in the resulting discussion.

Change History

1

Changed 7 months ago by exarkun

  • branch set to branches/no-global-reactor-testing-5371
  • branch_author set to exarkun

(In [33092]) Branching to 'no-global-reactor-testing-5371'

2

Changed 7 months ago by exarkun

  • owner exarkun deleted
  • keywords review added

3

Changed 7 months ago by frap

  • status changed from new to closed
  • resolution set to fixed

Documentation looks good and understandable. no formatiing errors nor spellling mistakes in browser. Makes sense to me.

4

Changed 7 months ago by itamar

  • status changed from closed to reopened
  • resolution fixed deleted

When reviewing branches, if you're done with the review you should remove the "review" keyword and reassign back to author, not close the ticket.

5

Changed 6 months ago by thijs

  • status changed from reopened to new
  • keywords review removed
  • owner set to exarkun

Looks good to merge.

6

Changed 6 months ago by itamar

There's a spelling mistake: "unweildy" instead of "unwieldy". Also maybe change the title from "Tips" to "Guidelines".

7

Changed 6 months ago by exarkun

(In [33115]) incorporate itamar's suggested improvements

refs #5371

8

Changed 6 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [33116]) Merge no-global-reactor-testing-5371

Author: exarkun Reviewer: frap, thijs, itamar Fixes: #5371

Codify the proscription on global reactor use in unit tests.

Note: See TracTickets for help on using tickets.