finger15.tac patch

[anv]

In the current version of finger15.tac the _read method has never been called. Proposal patch solves the problem.

Index: trunk/doc/core/howto/tutorial/listings/finger/finger15.tac
===================================================================
--- trunk/doc/core/howto/tutorial/listings/finger/finger15.tac	(revision 32505)
+++ trunk/doc/core/howto/tutorial/listings/finger/finger15.tac	(working copy)
@@ -79,6 +79,7 @@
 
 application = service.Application('finger', uid=1, gid=1)
 f = FingerService('/etc/users')
+f.setServiceParent(application)
 serviceCollection = service.IServiceCollection(application)
 internet.TCPServer(79, f.getFingerFactory()
                    ).setServiceParent(serviceCollection)

[anv]

Conceptually this is much better:

Index: trunk/doc/core/howto/tutorial/listings/finger/finger15.tac
===================================================================
--- trunk/doc/core/howto/tutorial/listings/finger/finger15.tac	(revision 30844)
+++ trunk/doc/core/howto/tutorial/listings/finger/finger15.tac	(working copy)
@@ -80,6 +80,7 @@
 application = service.Application('finger', uid=1, gid=1)
 f = FingerService('/etc/users')
 serviceCollection = service.IServiceCollection(application)
+f.setServiceParent(serviceCollection)
 internet.TCPServer(79, f.getFingerFactory()
                    ).setServiceParent(serviceCollection)
 internet.TCPServer(8000, server.Site(f.getResource())

[thijs]

Putting the patch up for review as described in the ReviewProcess.

[exarkun]

Thanks. Due to the construction of the finger tutorial, the mistake is duplicated in every subsequent tac as well. Would you like to attach a patch addressing all of them?

[anv]

The whole patch

[exarkun]

Thanks!

[exarkun]

(In [32568]) Apply tutorial_finger.patch fixing the finger tutorial listings to correctly construct the service hierarchy.

Author: anv Reviewer: exarkun Fixes: #5250

Fix many finger tutorial listings, which did not add the finger service to the service hierarchy, preventing the service from ever reading the user list.