#5208 defect new
SOCKv4 expects t.i.t.Port.getHost() to return a tuple
|Reported by:||lebek||Owned by:||lebek|
The BIND apparatus on SOCKv4 has to call getHost() on it's port to let a SOCKS client know where it's listening. It tries to slice the result of getHost() to return a (host, port) tuple - IPv4Address instances don't like being sliced!
This patch fixes the defect and also updates SOCKv4 to use its instance reactor instead of an imported one.
I'm not sure how to write tests for listenClass/connectClass, I think using an instance reactor at least makes this easier than it would have been, but I still need some direction (e.g. can I get rid of SOCKSv4Driver from the unit tests? use a custom reactor instead?).