IRCClient.msg loses data when splitting long messages
|Reported by:||jonathanj||Owned by:||jonathanj|
(github, coverage, patch, buildbot, log)
The length calculations used for splitting long messages don't take into account that when a message like PRIVMSG #foo <long_message> is relayed to other clients by the server it looks something like :nickname!user@host PRIVMSG #foo :<long_message> which is truncated at 510 characters. The current behaviour means that <long_message> loses an unspecified number of characters around the message limit mark for each line.
I think we have enough information to guess a safe maximum:
- Maximum nickname length can be determined from the ISUPPORT info (using our own current nickname may not always be correct.)
- Maximum username length seems to be something like 10 characters, I can't find any information on this limit.
- According to RFC 2812 the maximum hostname is 63 characters (our hostname can be changed on the server side at any point.)
Change History (14)
comment:9 follow-up: ↓ 11 Changed 5 years ago by jerith
- Cc jerith added
- Keywords review removed
- Owner set to jonathanj
comment:10 Changed 5 years ago by jonathanj
- Branch changed from branches/fix-ircclient-msg-split-5176 to branches/fix-ircclient-msg-split-5176-2