Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5146 defect closed fixed (fixed)

setup_args in top level setup.py created multiple times

Reported by: zseil Owned by: jesstess
Priority: normal Milestone:
Component: core Keywords:
Cc: Thijs Triemstra, jesstess Branch: branches/setup-args-5146
branch-diff, diff-cov, branch-cov, buildbot
Author: zseil

Description

The setup_args dictionary in Twisted's top level setup.py is created multiple times, once for each subproject, due to wrong indentation level.

Attachments (1)

setup.patch (2.5 KB) - added by zseil 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by zseil

Attachment: setup.patch added

comment:1 Changed 6 years ago by zseil

Keywords: review added

comment:2 Changed 6 years ago by Thijs Triemstra

Author: thijs
Branch: branches/setup-args-5146

(In [32186]) Branching to 'setup-args-5146'

comment:3 Changed 6 years ago by Thijs Triemstra

(In [32187]) apply setup.patch, add news file. refs #5146

comment:4 Changed 6 years ago by Thijs Triemstra

Author: thijszseil
Cc: Thijs Triemstra added

comment:5 Changed 6 years ago by jesstess

Owner: set to jesstess

comment:6 Changed 6 years ago by jesstess

Resolution: fixed
Status: newclosed

(In [32223]) Merge setup-args-5146

Author: zseil Reviewer: jesstess Fixes: #5146

Fix the indentation level of the setup_args dictionary in Twisted's top level setup.py so it isn't erroneously created several times.

comment:7 Changed 6 years ago by jesstess

Cc: jesstess added
Keywords: review removed

Thanks for the patch, zseil, and sorry for the delay in getting it reviewed!

Note: See TracTickets for help on using tickets.