Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#5146 defect closed fixed (fixed)

setup_args in top level setup.py created multiple times

Reported by: zseil Owned by: jesstess
Priority: normal Milestone:
Component: core Keywords:
Cc: thijs, jesstess Branch: branches/setup-args-5146
(diff, github, buildbot, log)
Author: zseil Launchpad Bug:

Description

The setup_args dictionary in Twisted's top level setup.py is created multiple times, once for each subproject, due to wrong indentation level.

Attachments (1)

setup.patch (2.5 KB) - added by zseil 3 years ago.

Download all attachments as: .zip

Change History (8)

Changed 3 years ago by zseil

comment:1 Changed 3 years ago by zseil

  • Keywords review added

comment:2 Changed 3 years ago by thijs

  • Author set to thijs
  • Branch set to branches/setup-args-5146

(In [32186]) Branching to 'setup-args-5146'

comment:3 Changed 3 years ago by thijs

(In [32187]) apply setup.patch, add news file. refs #5146

comment:4 Changed 3 years ago by thijs

  • Author changed from thijs to zseil
  • Cc thijs added

comment:5 Changed 3 years ago by jesstess

  • Owner set to jesstess

comment:6 Changed 3 years ago by jesstess

  • Resolution set to fixed
  • Status changed from new to closed

(In [32223]) Merge setup-args-5146

Author: zseil
Reviewer: jesstess
Fixes: #5146

Fix the indentation level of the setup_args dictionary in Twisted's
top level setup.py so it isn't erroneously created several times.

comment:7 Changed 3 years ago by jesstess

  • Cc jesstess added
  • Keywords review removed

Thanks for the patch, zseil, and sorry for the delay in getting it reviewed!

Note: See TracTickets for help on using tickets.