Ticket #5146 defect closed fixed

Opened 2 years ago

Last modified 23 months ago

setup_args in top level setup.py created multiple times

Reported by: zseil Owned by: jesstess
Priority: normal Milestone:
Component: core Keywords:
Cc: thijs, jesstess Branch: branches/setup-args-5146
Author: zseil Launchpad Bug:

Description

The setup_args dictionary in Twisted's top level setup.py is created multiple times, once for each subproject, due to wrong indentation level.

Attachments

setup.patch Download (2.5 KB) - added by zseil 2 years ago.

Change History

Changed 2 years ago by zseil

1

Changed 2 years ago by zseil

  • keywords review added

2

Changed 23 months ago by thijs

  • branch set to branches/setup-args-5146
  • branch_author set to thijs

(In [32186]) Branching to 'setup-args-5146'

3

Changed 23 months ago by thijs

(In [32187]) apply setup.patch, add news file. refs #5146

4

Changed 23 months ago by thijs

  • cc thijs added
  • branch_author changed from thijs to zseil

 Build results.

5

Changed 23 months ago by jesstess

  • owner set to jesstess

6

Changed 23 months ago by jesstess

  • status changed from new to closed
  • resolution set to fixed

(In [32223]) Merge setup-args-5146

Author: zseil Reviewer: jesstess Fixes: #5146

Fix the indentation level of the setup_args dictionary in Twisted's top level setup.py so it isn't erroneously created several times.

7

Changed 23 months ago by jesstess

  • keywords review removed
  • cc jesstess added

Thanks for the patch, zseil, and sorry for the delay in getting it reviewed!

Note: See TracTickets for help on using tickets.