t.i.p.BaseProtocol mentions unknow 'dataReceived'
|Reported by:||multani||Owned by:||exarkun|
(github, patch, buildbot, log)
Reading the API documentation of t.i.p.BaseProtocol, it says that:
... My API is quite simple. Implement dataReceived(data) ...
But dataReceived() is actually implemented by the subclass in t.i.p.Protocol.
If you read the documentation of BaseProtocol only, there's no way (AFAIK) that dataReceived() implemented by your subclass is going to be called. So I think andthe docstring of BaseProtocol should be updated not to mention dataReceived(). Otherwise, it just confuses reader.
Change History (7)
comment:6 Changed 5 years ago by jesstess
- Cc jesstess added
- Keywords review removed
- Owner set to exarkun